* [PATCH] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
@ 2026-08-11 4:19 Rosen Penev
2026-08-13 14:51 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-08-11 4:19 UTC (permalink / raw)
To: linux-sound
Cc: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, open list
The IRQ handler only needs the audio_drv_data, so pass it directly
as the request_irq argument instead of the device pointer and a
dev_get_drvdata() lookup.
Assisted-by: opencode:deepseek-v4-flash-free
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
sound/soc/amd/acp-pcm-dma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index e99588458ed8..60d5799c26f0 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -692,12 +692,10 @@ static irqreturn_t dma_irq_handler(int irq, void *arg)
{
u16 dscr_idx;
u32 intr_flag, ext_intr_status;
- struct audio_drv_data *irq_data;
+ struct audio_drv_data *irq_data = arg;
void __iomem *acp_mmio;
- struct device *dev = arg;
bool valid_irq = false;
- irq_data = dev_get_drvdata(dev);
acp_mmio = irq_data->acp_mmio;
ext_intr_status = acp_reg_read(acp_mmio, mmACP_EXTERNAL_INTR_STAT);
@@ -1295,7 +1293,7 @@ static int acp_audio_probe(struct platform_device *pdev)
return irq;
status = devm_request_irq(&pdev->dev, irq, dma_irq_handler,
- 0, "ACP_IRQ", &pdev->dev);
+ 0, "ACP_IRQ", audio_drv_data);
if (status) {
dev_err(&pdev->dev, "ACP IRQ request failed\n");
return status;
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
2026-08-11 4:19 [PATCH] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler Rosen Penev
@ 2026-08-13 14:51 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-08-13 14:51 UTC (permalink / raw)
To: linux-sound, Rosen Penev
Cc: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, linux-kernel
On Mon, 10 Aug 2026 21:19:25 -0700, Rosen Penev wrote:
> ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/1] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler
https://git.kernel.org/broonie/sound/c/0196c4b4f82b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-14 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-11 4:19 [PATCH] ASoC: amd: acp: pass audio_drv_data to dma_irq_handler Rosen Penev
2026-08-13 14:51 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®