* [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650
@ 2026-08-11 15:53 Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support Kathiravan Thirumoorthy
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-08-11 15:53 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Konrad Dybcio
Cc: linux-kernel, linux-arm-msm, linux-pm, devicetree, linux-clk,
Kathiravan Thirumoorthy, Konrad Dybcio, Dmitry Baryshkov
On Qualcomm IPQ9650 platform the interconnect busses don't have separate
RPM / RPMh controls. Instead they require direct votes through the GCC.
To unify hardware descriptions (and software interfaces) between this
platform and other Qualcomm platforms, make GCC export corresponding NoC
clocks as interconnects.
Add the necessary bindings and the drivers changes for the same.
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
Changes in v2:
- Picked up the tags
- Detailed commit message for the dt-binding patch
- Link to v1: https://patch.msgid.link/20260519-ipq9650_icc-v1-0-4d3554c94257@oss.qualcomm.com
To: Georgi Djakov <djakov@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
To: Brian Masney <bmasney@redhat.com>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-clk@vger.kernel.org
---
Kathiravan Thirumoorthy (3):
dt-bindings: interconnect: Add Qualcomm IPQ9650 support
clk: qcom: ipq9650: Use icc-clk for enabling NoC related clocks
arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node
arch/arm64/boot/dts/qcom/ipq9650.dtsi | 1 +
drivers/clk/qcom/gcc-ipq9650.c | 22 +++++++++++++++++++
include/dt-bindings/interconnect/qcom,ipq9650.h | 28 +++++++++++++++++++++++++
3 files changed, 51 insertions(+)
---
base-commit: 9eebf259d5352b87080d67758f483583d9e763d7
change-id: 20260519-ipq9650_icc-994280404adf
Best regards,
--
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support
2026-08-11 15:53 [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Kathiravan Thirumoorthy
@ 2026-08-11 15:53 ` Kathiravan Thirumoorthy
2026-08-13 8:34 ` Krzysztof Kozlowski
2026-08-11 15:53 ` [PATCH v2 2/3] clk: qcom: ipq9650: Use icc-clk for enabling NoC related clocks Kathiravan Thirumoorthy
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-08-11 15:53 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Konrad Dybcio
Cc: linux-kernel, linux-arm-msm, linux-pm, devicetree, linux-clk,
Kathiravan Thirumoorthy
On Qualcomm IPQ9650 platform the interconnect busses don't have separate
RPM / RPMh controls. Instead they require direct votes through the GCC.
To unify hardware descriptions (and software interfaces) between this
platform and other Qualcomm platforms, make GCC export corresponding NoC
clocks as interconnects. Add IDs for these Network-on-Chip interfaces.
The GCC schema already defines #interconnect-cells since it was added in
the commit f92b778251ad ("dt-bindings: clock: add Qualcomm IPQ9650
GCC").
Acked-by: Georgi Djakov <djakov@kernel.org>
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
include/dt-bindings/interconnect/qcom,ipq9650.h | 28 +++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/include/dt-bindings/interconnect/qcom,ipq9650.h b/include/dt-bindings/interconnect/qcom,ipq9650.h
new file mode 100644
index 000000000000..023a3878cc08
--- /dev/null
+++ b/include/dt-bindings/interconnect/qcom,ipq9650.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+#ifndef INTERCONNECT_QCOM_IPQ9650_H
+#define INTERCONNECT_QCOM_IPQ9650_H
+
+#define MASTER_ANOC_PCIE0 0
+#define SLAVE_ANOC_PCIE0 1
+#define MASTER_CNOC_PCIE0 2
+#define SLAVE_CNOC_PCIE0 3
+#define MASTER_ANOC_PCIE1 4
+#define SLAVE_ANOC_PCIE1 5
+#define MASTER_CNOC_PCIE1 6
+#define SLAVE_CNOC_PCIE1 7
+#define MASTER_ANOC_PCIE2 8
+#define SLAVE_ANOC_PCIE2 9
+#define MASTER_CNOC_PCIE2 10
+#define SLAVE_CNOC_PCIE2 11
+#define MASTER_ANOC_PCIE3 12
+#define SLAVE_ANOC_PCIE3 13
+#define MASTER_CNOC_PCIE3 14
+#define SLAVE_CNOC_PCIE3 15
+#define MASTER_ANOC_PCIE4 16
+#define SLAVE_ANOC_PCIE4 17
+#define MASTER_CNOC_PCIE4 18
+#define SLAVE_CNOC_PCIE4 19
+#define MASTER_SNOC_USB 20
+#define SLAVE_SNOC_USB 21
+
+#endif /* INTERCONNECT_QCOM_IPQ9650_H */
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] clk: qcom: ipq9650: Use icc-clk for enabling NoC related clocks
2026-08-11 15:53 [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support Kathiravan Thirumoorthy
@ 2026-08-11 15:53 ` Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 3/3] arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node Kathiravan Thirumoorthy
2026-09-29 3:14 ` (subset) [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-08-11 15:53 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Konrad Dybcio
Cc: linux-kernel, linux-arm-msm, linux-pm, devicetree, linux-clk,
Kathiravan Thirumoorthy, Konrad Dybcio, Dmitry Baryshkov
Register NoC clocks for PCIe and USB interconnect paths using the
icc-clk framework. Without this, the clocks required to create
interconnect paths and access peripherals connected to these NoCs are
not properly managed.
Also add icc_sync_state to ensure clock states are synchronized after all
consumers have probed.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/clk/qcom/gcc-ipq9650.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/clk/qcom/gcc-ipq9650.c b/drivers/clk/qcom/gcc-ipq9650.c
index e65a52fdfa91..8c09a757c11d 100644
--- a/drivers/clk/qcom/gcc-ipq9650.c
+++ b/drivers/clk/qcom/gcc-ipq9650.c
@@ -4,11 +4,13 @@
*/
#include <linux/clk-provider.h>
+#include <linux/interconnect-provider.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <dt-bindings/clock/qcom,ipq9650-gcc.h>
+#include <dt-bindings/interconnect/qcom,ipq9650.h>
#include <dt-bindings/reset/qcom,ipq9650-gcc.h>
#include "clk-alpha-pll.h"
@@ -3474,6 +3476,22 @@ static const struct qcom_reset_map gcc_ipq9650_resets[] = {
[GCC_USB_BCR] = { 0x2c000 },
};
+#define IPQ_APPS_ID 9650 /* some unique value */
+
+static const struct qcom_icc_hws_data icc_ipq9650_hws[] = {
+ { MASTER_ANOC_PCIE0, SLAVE_ANOC_PCIE0, GCC_ANOC_PCIE0_1LANE_M_CLK },
+ { MASTER_CNOC_PCIE0, SLAVE_CNOC_PCIE0, GCC_ANOC_PCIE0_1LANE_S_CLK },
+ { MASTER_ANOC_PCIE1, SLAVE_ANOC_PCIE1, GCC_ANOC_PCIE1_2LANE_M_CLK },
+ { MASTER_CNOC_PCIE1, SLAVE_CNOC_PCIE1, GCC_ANOC_PCIE1_2LANE_S_CLK },
+ { MASTER_ANOC_PCIE2, SLAVE_ANOC_PCIE2, GCC_ANOC_PCIE2_2LANE_M_CLK },
+ { MASTER_CNOC_PCIE2, SLAVE_CNOC_PCIE2, GCC_ANOC_PCIE2_2LANE_S_CLK },
+ { MASTER_ANOC_PCIE3, SLAVE_ANOC_PCIE3, GCC_ANOC_PCIE3_2LANE_M_CLK },
+ { MASTER_CNOC_PCIE3, SLAVE_CNOC_PCIE3, GCC_ANOC_PCIE3_2LANE_S_CLK },
+ { MASTER_ANOC_PCIE4, SLAVE_ANOC_PCIE4, GCC_ANOC_PCIE4_1LANE_M_CLK },
+ { MASTER_CNOC_PCIE4, SLAVE_CNOC_PCIE4, GCC_ANOC_PCIE4_1LANE_S_CLK },
+ { MASTER_SNOC_USB, SLAVE_SNOC_USB, GCC_SNOC_USB_CLK },
+};
+
static const struct of_device_id gcc_ipq9650_match_table[] = {
{ .compatible = "qcom,ipq9650-gcc" },
{ }
@@ -3503,6 +3521,9 @@ static const struct qcom_cc_desc gcc_ipq9650_desc = {
.num_resets = ARRAY_SIZE(gcc_ipq9650_resets),
.clk_hws = gcc_ipq9650_hws,
.num_clk_hws = ARRAY_SIZE(gcc_ipq9650_hws),
+ .icc_hws = icc_ipq9650_hws,
+ .num_icc_hws = ARRAY_SIZE(icc_ipq9650_hws),
+ .icc_first_node_id = IPQ_APPS_ID,
};
static int gcc_ipq9650_probe(struct platform_device *pdev)
@@ -3515,6 +3536,7 @@ static struct platform_driver gcc_ipq9650_driver = {
.driver = {
.name = "qcom,gcc-ipq9650",
.of_match_table = gcc_ipq9650_match_table,
+ .sync_state = icc_sync_state,
},
};
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node
2026-08-11 15:53 [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 2/3] clk: qcom: ipq9650: Use icc-clk for enabling NoC related clocks Kathiravan Thirumoorthy
@ 2026-08-11 15:53 ` Kathiravan Thirumoorthy
2026-09-29 3:14 ` (subset) [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-08-11 15:53 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Konrad Dybcio
Cc: linux-kernel, linux-arm-msm, linux-pm, devicetree, linux-clk,
Kathiravan Thirumoorthy, Konrad Dybcio, Dmitry Baryshkov
Add the '#interconnect-cells' property to the GCC clock controller node
to allow NOC-related clocks to be managed via the icc-clk framework.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/ipq9650.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9650.dtsi b/arch/arm64/boot/dts/qcom/ipq9650.dtsi
index 3d3b317c6a3c..4c442773de53 100644
--- a/arch/arm64/boot/dts/qcom/ipq9650.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9650.dtsi
@@ -225,6 +225,7 @@ gcc: clock-controller@1800000 {
<0>;
#clock-cells = <1>;
#reset-cells = <1>;
+ #interconnect-cells = <1>;
};
tcsr_mutex: hwlock@1917000 {
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support
2026-08-11 15:53 ` [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support Kathiravan Thirumoorthy
@ 2026-08-13 8:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-13 8:34 UTC (permalink / raw)
To: Kathiravan Thirumoorthy
Cc: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
Konrad Dybcio, linux-kernel, linux-arm-msm, linux-pm, devicetree,
linux-clk
On Tue, Aug 11, 2026 at 09:23:08PM +0530, Kathiravan Thirumoorthy wrote:
> On Qualcomm IPQ9650 platform the interconnect busses don't have separate
> RPM / RPMh controls. Instead they require direct votes through the GCC.
> To unify hardware descriptions (and software interfaces) between this
> platform and other Qualcomm platforms, make GCC export corresponding NoC
> clocks as interconnects. Add IDs for these Network-on-Chip interfaces.
> The GCC schema already defines #interconnect-cells since it was added in
> the commit f92b778251ad ("dt-bindings: clock: add Qualcomm IPQ9650
> GCC").
>
> Acked-by: Georgi Djakov <djakov@kernel.org>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> include/dt-bindings/interconnect/qcom,ipq9650.h | 28 +++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650
2026-08-11 15:53 [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Kathiravan Thirumoorthy
` (2 preceding siblings ...)
2026-08-11 15:53 ` [PATCH v2 3/3] arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node Kathiravan Thirumoorthy
@ 2026-09-29 3:14 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2026-09-29 3:14 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Michael Turquette, Stephen Boyd, Brian Masney, Konrad Dybcio,
Kathiravan Thirumoorthy
Cc: linux-kernel, linux-arm-msm, linux-pm, devicetree, linux-clk,
Konrad Dybcio, Dmitry Baryshkov
On Tue, 11 Aug 2026 21:23:07 +0530, Kathiravan Thirumoorthy wrote:
> On Qualcomm IPQ9650 platform the interconnect busses don't have separate
> RPM / RPMh controls. Instead they require direct votes through the GCC.
> To unify hardware descriptions (and software interfaces) between this
> platform and other Qualcomm platforms, make GCC export corresponding NoC
> clocks as interconnects.
>
> Add the necessary bindings and the drivers changes for the same.
>
> [...]
Applied, thanks!
[3/3] arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node
commit: 5187d5790a7945362ca8133b937c0af8b770542e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-29 3:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-11 15:53 [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 1/3] dt-bindings: interconnect: Add Qualcomm IPQ9650 support Kathiravan Thirumoorthy
2026-08-13 8:34 ` Krzysztof Kozlowski
2026-08-11 15:53 ` [PATCH v2 2/3] clk: qcom: ipq9650: Use icc-clk for enabling NoC related clocks Kathiravan Thirumoorthy
2026-08-11 15:53 ` [PATCH v2 3/3] arm64: dts: qcom: ipq9650: add interconnect-cells to GCC node Kathiravan Thirumoorthy
2026-09-29 3:14 ` (subset) [PATCH v2 0/3] Enable icc-clk support for Qualcomm IPQ9650 Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®