From: Arka Mondal <arkamondalofficial@gmail.com>
To: nuno.sa@analog.com, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: dlechner@baylibre.com, andy@kernel.org,
venkat.prashanth2498@gmail.com, rohitsarkar5398@gmail.com,
linux@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Arka Mondal <arkamondalofficial@gmail.com>
Subject: [PATCH 1/3] iio: imu: adis16480: fix unprotected debugfs reads
Date: Fri, 14 Aug 2026 18:07:26 +0900 [thread overview]
Message-ID: <20260814090728.965922-1-arkamondalofficial@gmail.com> (raw)
The firmware_revision and firmware_date file operations are open coded
and never call debugfs_file_get(), which debugfs_create_file_unsafe()
requires. debugfs_remove_recursive() therefore does not wait for a read
in progress, and unbind frees the iio_dev underneath it.
Use debugfs_create_file() instead.
Fixes: 9bf94f836e32 ("imu:adis16480: fix debugfs_simple_attr.cocci warnings")
Signed-off-by: Arka Mondal <arkamondalofficial@gmail.com>
---
Compile tested only; no relevant hardware available.
drivers/iio/imu/adis16480.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
index e009f3824768..254b7ff25b66 100644
--- a/drivers/iio/imu/adis16480.c
+++ b/drivers/iio/imu/adis16480.c
@@ -309,9 +309,9 @@ static void adis16480_debugfs_init(struct iio_dev *indio_dev)
if (!IS_ENABLED(CONFIG_DEBUG_FS))
return;
- debugfs_create_file_unsafe("firmware_revision", 0400,
+ debugfs_create_file("firmware_revision", 0400,
d, adis16480, &adis16480_firmware_revision_fops);
- debugfs_create_file_unsafe("firmware_date", 0400,
+ debugfs_create_file("firmware_date", 0400,
d, adis16480, &adis16480_firmware_date_fops);
debugfs_create_file_unsafe("serial_number", 0400,
d, adis16480, &adis16480_serial_number_fops);
--
2.55.0
next reply other threads:[~2026-08-14 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:07 Arka Mondal [this message]
2026-08-14 9:07 ` [PATCH 2/3] iio: imu: adis16400: " Arka Mondal
2026-08-15 8:42 ` Andy Shevchenko
2026-08-22 21:37 ` Jonathan Cameron
2026-08-24 8:29 ` Andy Shevchenko
2026-08-14 9:07 ` [PATCH 3/3] iio: gyro: adis16136: " Arka Mondal
2026-08-15 8:49 ` Andy Shevchenko
2026-08-22 21:39 ` Jonathan Cameron
2026-08-15 8:47 ` [PATCH 1/3] iio: imu: adis16480: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814090728.965922-1-arkamondalofficial@gmail.com \
--to=arkamondalofficial@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=rohitsarkar5398@gmail.com \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®