From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Arka Mondal <arkamondalofficial@gmail.com>,
nuno.sa@analog.com, Michael.Hennerich@analog.com,
dlechner@baylibre.com, andy@kernel.org,
venkat.prashanth2498@gmail.com, rohitsarkar5398@gmail.com,
linux@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: imu: adis16400: fix unprotected debugfs reads
Date: Mon, 24 Aug 2026 11:29:29 +0300 [thread overview]
Message-ID: <aowA6WnmgpZwdl6z@ashevche-desk.local> (raw)
In-Reply-To: <20260822223753.21b1b417@jic23-huawei>
On Sat, Aug 22, 2026 at 10:37:53PM +0100, Jonathan Cameron wrote:
> On Sat, 15 Aug 2026 11:42:30 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>
> > On Fri, Aug 14, 2026 at 06:07:27PM +0900, Arka Mondal wrote:
> > > The serial_number file operations are open coded and never call
> > > debugfs_file_get(), which debugfs_create_file_unsafe() requires.
> > > debugfs_remove_recursive() therefore does not wait for a read in
> > > progress, and unbind frees the iio_dev underneath it.
> > >
> > > Use debugfs_create_file() instead.
> >
> > Have you read the code? Have you read the commit message of the "culprit"
> > commit?
> >
> > NAK. Please, revisit all your patches and be careful next time.
> >
> FWIW it is curious that the original patch didn't touch the serial number
> declaration whilst touching the other two. Superficially that looks
> like an omission we missed in review.
I see, yes, it some strange case of missing piece during review.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-24 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:07 [PATCH 1/3] iio: imu: adis16480: " Arka Mondal
2026-08-14 9:07 ` [PATCH 2/3] iio: imu: adis16400: " Arka Mondal
2026-08-15 8:42 ` Andy Shevchenko
2026-08-22 21:37 ` Jonathan Cameron
2026-08-24 8:29 ` Andy Shevchenko [this message]
2026-08-14 9:07 ` [PATCH 3/3] iio: gyro: adis16136: " Arka Mondal
2026-08-15 8:49 ` Andy Shevchenko
2026-08-22 21:39 ` Jonathan Cameron
2026-08-15 8:47 ` [PATCH 1/3] iio: imu: adis16480: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aowA6WnmgpZwdl6z@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=arkamondalofficial@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=rohitsarkar5398@gmail.com \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®