From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Martin Roukala (né Peres)" <martin.roukala@mupuf.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Magne Bruno" <magne.bruno@addi-data.com>,
"Crescent Hsieh" <crescentcy.hsieh@moxa.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH] serial: 8250_pci: Catch up on new pci_device_id entry without named initializer
Date: Fri, 14 Aug 2026 11:59:31 +0200 [thread overview]
Message-ID: <20260814095931.1871387-2-u.kleine-koenig@baylibre.com> (raw)
When the patch that became 0481a041e956 ("serial: 8250: split Moxa PCIe
serial board support out of 8250_pci") was created, commit 44e55f1f3088
("serial: 8250_pci: Consistently define pci_device_ids using named
initializers") wasn't applied yet and thus added an assignment to
.driver_data without using a named initializer. Adapt the assignment to
make the array consistent again and re-prepare the driver for the planned
change to struct pci_device_id.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,
if you prefer it, feel free to squash this change into 0481a041e956.
Otherwise I don't think this change justifies a Fixes: trailer, but
still it would be nice to get this in during the upcoming merge window.
Best regards
Uwe
drivers/tty/serial/8250/8250_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index c24a59896982..6e53d6d72a8e 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3894,7 +3894,7 @@ static const struct pci_device_id blacklist[] = {
{ PCI_VDEVICE(ACCESSIO, PCI_ANY_ID), .driver_data = REPORT_8250_CONFIG(PERICOM), },
/* Moxa devices */
- { PCI_VDEVICE(MOXA, PCI_ANY_ID), REPORT_8250_CONFIG(MOXA), },
+ { PCI_VDEVICE(MOXA, PCI_ANY_ID), .driver_data = REPORT_8250_CONFIG(MOXA), },
/* End of the black list */
{ }
base-commit: 0481a041e9569dfc2448ba4c6cb30335fcb8430f
--
2.55.0.11.g153666a7d9bb
next reply other threads:[~2026-08-14 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:59 Uwe Kleine-König (The Capable Hub) [this message]
2026-09-16 5:56 ` Uwe Kleine-König (The Capable Hub)
2026-09-16 7:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814095931.1871387-2-u.kleine-koenig@baylibre.com \
--to=u.kleine-koenig@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=crescentcy.hsieh@moxa.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=magne.bruno@addi-data.com \
--cc=martin.roukala@mupuf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®