From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Martin Roukala (né Peres)" <martin.roukala@mupuf.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Magne Bruno" <magne.bruno@addi-data.com>,
"Crescent Hsieh" <crescentcy.hsieh@moxa.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: Catch up on new pci_device_id entry without named initializer
Date: Wed, 16 Sep 2026 09:19:23 +0200 [thread overview]
Message-ID: <2026091608-twistable-jaundice-6138@gregkh> (raw)
In-Reply-To: <aqovRVuGLvfSLLPr@monoceros>
On Wed, Sep 16, 2026 at 07:56:08AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Helo Greg,
>
> On Fri, Aug 14, 2026 at 11:59:31AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > When the patch that became 0481a041e956 ("serial: 8250: split Moxa PCIe
> > serial board support out of 8250_pci") was created, commit 44e55f1f3088
> > ("serial: 8250_pci: Consistently define pci_device_ids using named
> > initializers") wasn't applied yet and thus added an assignment to
> > .driver_data without using a named initializer. Adapt the assignment to
> > make the array consistent again and re-prepare the driver for the planned
> > change to struct pci_device_id.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> > ---
> > Hello,
> >
> > if you prefer it, feel free to squash this change into 0481a041e956.
> > Otherwise I don't think this change justifies a Fixes: trailer, but
> > still it would be nice to get this in during the upcoming merge window.
>
> Is this patch still on your radar?
Yes, along with a few thousand more, sorry, way behind in reviews...
prev parent reply other threads:[~2026-09-16 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:59 Uwe Kleine-König (The Capable Hub)
2026-09-16 5:56 ` Uwe Kleine-König (The Capable Hub)
2026-09-16 7:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026091608-twistable-jaundice-6138@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=crescentcy.hsieh@moxa.com \
--cc=dave.jiang@intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=magne.bruno@addi-data.com \
--cc=martin.roukala@mupuf.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®