* [PATCH] spi: dw: Remove shadowed dws in dw_spi_setup()
@ 2026-08-14 11:42 Liang Hao
2026-08-14 12:34 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Liang Hao @ 2026-08-14 11:42 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel, Liang Hao
The controller private data is already fetched at the start of
dw_spi_setup(). Drop the redundant inner declaration that shadows it.
Signed-off-by: Liang Hao <haohlliang@gmail.com>
---
drivers/spi/spi-dw-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index dfce2fa20adf..206d3f9dd83d 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -1098,7 +1098,6 @@ static int dw_spi_setup(struct spi_device *spi)
/* Only alloc on first setup */
chip = spi_get_ctldata(spi);
if (!chip) {
- struct dw_spi *dws = spi_controller_get_devdata(spi->controller);
u32 rx_sample_dly_ns;
chip = kzalloc_obj(*chip);
--
2.50.1 (Apple Git-155)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: dw: Remove shadowed dws in dw_spi_setup()
2026-08-14 11:42 [PATCH] spi: dw: Remove shadowed dws in dw_spi_setup() Liang Hao
@ 2026-08-14 12:34 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-08-14 12:34 UTC (permalink / raw)
To: Liang Hao; +Cc: linux-spi, linux-kernel
On Fri, 14 Aug 2026 19:42:35 +0800, Liang Hao wrote:
> spi: dw: Remove shadowed dws in dw_spi_setup()
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.3
Thanks!
[1/1] spi: dw: Remove shadowed dws in dw_spi_setup()
https://git.kernel.org/broonie/spi/c/11dfeb73d1f9
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-14 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-14 11:42 [PATCH] spi: dw: Remove shadowed dws in dw_spi_setup() Liang Hao
2026-08-14 12:34 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®