mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guanjie Chen <jk.chen1095@gmail.com>
To: wqu@suse.com
Cc: clm@fb.com, dsterba@suse.com, fdmanana@suse.com,
	jk.chen1095@gmail.com, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: free qgroup configuration when quota enable fails
Date: Sat, 15 Aug 2026 14:44:59 +0800	[thread overview]
Message-ID: <20260815064503.67385-1-jk.chen1095@gmail.com> (raw)
In-Reply-To: <7845cec2-adf1-408f-b7eb-019a5cd398f7@suse.com>

Hi Qu,

Thanks for the review.

I agree the error path should be reversed, even though btrfs_free_qgroup_config() has defensive checks so it won't UAF. But this isn't a one-liner – maybe we can refactor the whole init/cleanup flow later and fix it properly.

As for contributing: I know there's been lots of LLM noise lately, and I don't want to add to it. I've been studying btrfs for about 2~3 years now. For my next patch, would it help if I clearly explain the root cause, my reasoning, and the solution in the commit message or cover letter? I'd like to make review smoother.

Thanks again for your time.

Best,
Guanjie

  reply	other threads:[~2026-08-15  6:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 11:22 Guanjie Chen
2026-08-14 11:49 ` Qu Wenruo
2026-08-14 12:30   ` Guanjie Chen
2026-08-14 22:13     ` Qu Wenruo
2026-08-15  6:44       ` Guanjie Chen [this message]
2026-08-15  8:03         ` Qu Wenruo
     [not found] <d239645a-b291-4fe9-b256-f0be849c875a@suse.com@suse.com>
2026-08-15  9:00 ` Guanjie Chen
2026-08-15  9:08   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260815064503.67385-1-jk.chen1095@gmail.com \
    --to=jk.chen1095@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=fdmanana@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®