From: Rustam Adilov <adilov@disroot.org>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Sander Vanheule <sander@svanheule.net>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rustam Adilov <adilov@disroot.org>
Subject: [PATCH v2 1/2] gpio: realtek-otto: use __raw_readl/writel in realtek_gpio_update_line_imr()
Date: Sat, 15 Aug 2026 14:44:50 +0500 [thread overview]
Message-ID: <20260815094451.31792-2-adilov@disroot.org> (raw)
In-Reply-To: <20260815094451.31792-1-adilov@disroot.org>
In preparation for upcoming changes to how bank reads and writes
are defined in this driver, change the ioread32 and iowrite32 to
their __raw variants. The realtek_gpio_update_line_imr() function
is used by all devices regardless of GPIO_PORTS_REVERSED flag and
thus this is the only place where there shouldn't be any byte
swapping whether SWAP_IO_SPACE config is enabled or not and that
is only possible with __raw_readl and __raw_writel.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Rustam Adilov <adilov@disroot.org>
---
drivers/gpio/gpio-realtek-otto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index 4a606bad5848..491fde846d46 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -176,10 +176,10 @@ static void realtek_gpio_update_line_imr(struct realtek_gpio_ctrl *ctrl, unsigne
u32 reg_val;
reg += 4 * (line_shift / 32);
- reg_val = ioread32(reg);
+ reg_val = __raw_readl(reg);
reg_val &= ~(REALTEK_GPIO_IMR_LINE_MASK << shift);
reg_val |= (irq_type & irq_mask & REALTEK_GPIO_IMR_LINE_MASK) << shift;
- iowrite32(reg_val, reg);
+ __raw_writel(reg_val, reg);
}
static void realtek_gpio_irq_ack(struct irq_data *data)
--
2.55.0
next prev parent reply other threads:[~2026-08-15 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 9:44 [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE Rustam Adilov
2026-08-15 9:44 ` Rustam Adilov [this message]
2026-08-15 9:44 ` [PATCH v2 2/2] gpio: realtek-otto: make bank_read/write overridable by endian property Rustam Adilov
2026-09-01 15:55 ` [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE Bartosz Golaszewski
2026-09-28 9:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815094451.31792-2-adilov@disroot.org \
--to=adilov@disroot.org \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®