mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rustam Adilov <adilov@disroot.org>
Cc: Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Sander Vanheule <sander@svanheule.net>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE
Date: Mon, 28 Sep 2026 11:51:37 +0200	[thread overview]
Message-ID: <aro4qbhcd3X6wTvP@black.igk.intel.com> (raw)
In-Reply-To: <20260815094451.31792-1-adilov@disroot.org>

On Sat, Aug 15, 2026 at 02:44:49PM +0500, Rustam Adilov wrote:
> This patch series changes gpio-realtek-otto to be functional around
> SWAP_IO_SPACE config.
> 
> Firstly the ioread32 and iowrite32 in realtek_gpio_update_line_imr()
> have to be changed to their __raw variants as it is the only point in
> the driver where both devices with ports reversed and without meet.
> 
> Secondly, the bank_read/write and the flag for generic gpio config
> have to be able to be changed to the opposite one when SWAP_IO_SPACE
> is enabled. To avoid breaking any existing device tree out in the wild,
> make them overridable by endian properties from the device tree node and
> keep the current GPIO_PORTS_REVERSED quirk as it is.
> 
> I have tested it on my RTL9607C machine with SWAP_IO_SPACE enabled
> and with big-endian property set under gpio controller node and it
> was working fine.

Convert the driver to use regmap MMIO and most of the code in this series won't
be needed. Also it will give some benefits (like register caching and debugfs
monitoring).

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-09-28  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15  9:44 Rustam Adilov
2026-08-15  9:44 ` [PATCH v2 1/2] gpio: realtek-otto: use __raw_readl/writel in realtek_gpio_update_line_imr() Rustam Adilov
2026-08-15  9:44 ` [PATCH v2 2/2] gpio: realtek-otto: make bank_read/write overridable by endian property Rustam Adilov
2026-09-01 15:55 ` [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE Bartosz Golaszewski
2026-09-28  9:51 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aro4qbhcd3X6wTvP@black.igk.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=adilov@disroot.org \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sander@svanheule.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®