[PATCH] rtl8723bs: remove misleading comment

[PATCH] rtl8723bs: remove misleading comment

[Omer El Idrissi]

The comment says that rtw_unregister_cmd_alive function is called by
the ISR while it is called by rtw_cmd_thread which runs in the kernel
thread context, which is why it's being removed.

Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index b9f8cf1014ed..a0ae2849f2d7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -891,8 +891,6 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
 }
 
 /*
- * Caller: ISR
- *
  * If all commands have been done,
  * and no more command to do,
  * then driver shall call this fun. to power down firmware again.
-- 
2.53.0

Re: [PATCH] rtl8723bs: remove misleading comment

[Greg KH]

On Sat, Aug 22, 2026 at 11:39:42AM +0200, Omer El Idrissi wrote:
> The comment says that rtw_unregister_cmd_alive function is called by
> the ISR while it is called by rtw_cmd_thread which runs in the kernel
> thread context, which is why it's being removed.
> 
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index b9f8cf1014ed..a0ae2849f2d7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -891,8 +891,6 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
>  }
>  
>  /*
> - * Caller: ISR
> - *
>   * If all commands have been done,
>   * and no more command to do,
>   * then driver shall call this fun. to power down firmware again.
> -- 
> 2.53.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot