mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
       [not found] <20260823-rtl8723b-cmd-space-before-tab-fix-v1-1-452d83d8718c.ref@yahoo.pl>
@ 2026-08-23 16:01 ` Tomasz Unger
  2026-08-23 16:49   ` Greg Kroah-Hartman
  2026-08-23 19:05   ` Dan Carpenter
  0 siblings, 2 replies; 3+ messages in thread
From: Tomasz Unger @ 2026-08-23 16:01 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Tomasz Unger

Remove stray spaces and tabs before a commented-out line.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Verified with checkpatch.pl - no new warnings introduced by this change.
---
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index d2b44ad60a4c..d39ddf396f64 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -895,7 +895,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter)
 		DLBcnCount++;
 		do {
 			yield();
-/* 			mdelay(10); */
+/* mdelay(10); */
 			/*  check rsvd page download OK. */
 			rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid);
 			poll++;

---
base-commit: c6eb4dc5964fdf4086b73b7f0f5dc0d595fb5cf3
change-id: 20260823-rtl8723b-cmd-space-before-tab-fix-9d6b4298d061

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
  2026-08-23 16:01 ` [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
@ 2026-08-23 16:49   ` Greg Kroah-Hartman
  2026-08-23 19:05   ` Dan Carpenter
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-08-23 16:49 UTC (permalink / raw)
  To: Tomasz Unger; +Cc: linux-staging, linux-kernel

On Sun, Aug 23, 2026 at 06:01:43PM +0200, Tomasz Unger wrote:
> Remove stray spaces and tabs before a commented-out line.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Verified with checkpatch.pl - no new warnings introduced by this change.
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index d2b44ad60a4c..d39ddf396f64 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -895,7 +895,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter)
>  		DLBcnCount++;
>  		do {
>  			yield();
> -/* 			mdelay(10); */
> +/* mdelay(10); */

Does that look correct?

Also, you have sent a bunch of patches, they should be a patch series,
otherwise how do we know what order they should be applied in?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment
  2026-08-23 16:01 ` [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
  2026-08-23 16:49   ` Greg Kroah-Hartman
@ 2026-08-23 19:05   ` Dan Carpenter
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-08-23 19:05 UTC (permalink / raw)
  To: Tomasz Unger; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel

On Sun, Aug 23, 2026 at 06:01:43PM +0200, Tomasz Unger wrote:
> Remove stray spaces and tabs before a commented-out line.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Verified with checkpatch.pl - no new warnings introduced by this change.
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index d2b44ad60a4c..d39ddf396f64 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -895,7 +895,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter)
>  		DLBcnCount++;
>  		do {
>  			yield();
> -/* 			mdelay(10); */
> +/* mdelay(10); */

Just delete dead code.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-23 19:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20260823-rtl8723b-cmd-space-before-tab-fix-v1-1-452d83d8718c.ref@yahoo.pl>
2026-08-23 16:01 ` [PATCH] staging: rtl8723bs: fix space before tab in rtl8723b_cmd.c comment Tomasz Unger
2026-08-23 16:49   ` Greg Kroah-Hartman
2026-08-23 19:05   ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®