mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Pettit <jason.pettit@oss.qualcomm.com>
To: Nabige Aala <nabige.aala@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Wesley Cheng <wesley.cheng@oss.qualcomm.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Jason Pettit <jason.pettit@oss.qualcomm.com>,
	Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>,
	Mahadevan P <mahadevan.p@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur
Date: Sun, 23 Aug 2026 18:41:25 -0700	[thread overview]
Message-ID: <20260824014125.2210-1-jason.pettit@oss.qualcomm.com> (raw)
In-Reply-To: <20260822142508.25473-1-jason.pettit@oss.qualcomm.com>

Correcting myself. My earlier reply was wrong and I apologise for the noise.

I said the include had "dp" and "qserdes" transposed. It does not. The file

  drivers/phy/qualcomm/phy-qcom-qmp-dp-qserdes-com-v8.h

exists in v7.2 and the include was correct when this patch was posted on
21 July. I checked only current linux-next and drew the wrong conclusion.

What actually changed is a later cleanup.

  4b04c8779a50 ("phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers")

authored 22 July, merged 7 August. It removed that header as a duplicate of
phy-qcom-qmp-qserdes-dp-com-v8.h, reverting d10736db98d2. So the build break
on current linux-next is a rebase consequence, not an error in the patch.

The practical fix is unchanged. On a tree that has 4b04c8779a50, the include
needs to become

  #include "phy-qcom-qmp-qserdes-dp-com-v8.h"

which still supplies DP_QSERDES_V8_COM_C_READY_STATUS and
DP_QSERDES_V8_COM_CMN_STATUS.

The other point in my earlier reply stands. eca0e717aab1 ("phy: qualcomm:
qmp-combo: Add support for Hawi SoC") added lines to the same include block
on 3 August, so "git am -3" is needed to apply this cleanly.

Sorry again for the misdiagnosis.

Thanks,
Jason

  reply	other threads:[~2026-08-24  1:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  5:18 Nabige Aala
2026-07-21 23:26 ` Dmitry Baryshkov
2026-08-21  6:04   ` Nabige Aala
2026-08-22 14:25 ` Jason Pettit
2026-08-24  1:41   ` Jason Pettit [this message]
2026-08-24  5:59   ` Nabige Aala
  -- strict thread matches above, loose matches on Subject: below --
2026-04-19 10:15 Mahadevan P
2026-04-19 13:18 ` Dmitry Baryshkov
2026-04-20 14:18   ` Mahadevan P
2026-04-22  9:54     ` Konrad Dybcio
2026-04-22 15:40       ` Dmitry Baryshkov
2026-04-22  9:36 ` Konrad Dybcio
2026-04-22 10:06 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824014125.2210-1-jason.pettit@oss.qualcomm.com \
    --to=jason.pettit@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mahadevan.p@oss.qualcomm.com \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=ritesh.kumar@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    --cc=wesley.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®