* [PATCH net] net: mvpp2: Fix IRQ error handling
@ 2026-08-24 10:07 phucduc.bui
0 siblings, 0 replies; only message in thread
From: phucduc.bui @ 2026-08-24 10:07 UTC (permalink / raw)
To: Marcin Wojtas, Russell King
Cc: Andrew Lunn, davem, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Thomas Petazzoni, linux-kernel, netdev, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
The current code does not handle this return value correctly.
Check for a zero return value and return -EINVAL when the IRQ lookup
fails.
Fixes: 591f4cfab38a ("net: mvpp2: introduce queue_vector concept")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index ccc24a1301f2..1c50174c9f1e 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5874,7 +5874,7 @@ static int mvpp2_simple_queue_vectors_init(struct mvpp2_port *port,
v->sw_thread_mask = *cpumask_bits(cpu_online_mask);
v->port = port;
v->irq = irq_of_parse_and_map(port_node, 0);
- if (v->irq <= 0)
+ if (!v->irq)
return -EINVAL;
netif_napi_add(port->dev, &v->napi, mvpp2_poll);
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-24 10:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-24 10:07 [PATCH net] net: mvpp2: Fix IRQ error handling phucduc.bui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®