mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
@ 2026-08-24 15:14 Geert Uytterhoeven
  2026-08-25  8:01 ` Christoph Hellwig
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-08-24 15:14 UTC (permalink / raw)
  To: Christoph Hellwig, Andrew Morton, Eric Biggers, Ard Biesheuvel
  Cc: linux-kselftest, linux-kernel, Geert Uytterhoeven

Enabling the (possibly long-running benchmarks) by default may cause a
big delay in boot time in case of built-in tests.  However, they can
still safely be enabled by default if all tests are modular, as they
would only run when requested explicitly by the system administrator.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 lib/raid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/raid/Kconfig b/lib/raid/Kconfig
index 01f007b2522cfc33..563a178aa930c420 100644
--- a/lib/raid/Kconfig
+++ b/lib/raid/Kconfig
@@ -32,6 +32,7 @@ config XOR_KUNIT_TEST
 config XOR_BENCHMARK
 	bool "Benchmark for xor_gen"
 	depends on XOR_KUNIT_TEST
+	default y if KUNIT_ALL_TESTS=m
 	help
 	  Include benchmarks in the KUnit test suite for xor_gen.
 
@@ -63,6 +64,7 @@ config RAID6_PQ_KUNIT_TEST
 config RAID6_PQ_KUNIT_BENCHMARK
 	bool "Benchmark for RAID6 PQ"
 	depends on RAID6_PQ_KUNIT_TEST
+	default y if KUNIT_ALL_TESTS=m
 	help
 	  Include benchmarks in the KUnit test suite for raid P/Q generation.
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
@ 2026-08-25  8:01 ` Christoph Hellwig
  2026-08-25  8:32 ` Ard Biesheuvel
  2026-08-27  3:50 ` Andrew Morton
  2 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-08-25  8:01 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Christoph Hellwig, Andrew Morton, Eric Biggers, Ard Biesheuvel,
	linux-kselftest, linux-kernel

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
  2026-08-25  8:01 ` Christoph Hellwig
@ 2026-08-25  8:32 ` Ard Biesheuvel
  2026-08-27  3:50 ` Andrew Morton
  2 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2026-08-25  8:32 UTC (permalink / raw)
  To: Geert Uytterhoeven, Christoph Hellwig, Andrew Morton, Eric Biggers
  Cc: linux-kselftest, linux-kernel


On Mon, 24 Aug 2026, at 17:14, Geert Uytterhoeven wrote:
> Enabling the (possibly long-running benchmarks) by default may cause a
> big delay in boot time in case of built-in tests.  However, they can
> still safely be enabled by default if all tests are modular, as they
> would only run when requested explicitly by the system administrator.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  lib/raid/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
  2026-08-25  8:01 ` Christoph Hellwig
  2026-08-25  8:32 ` Ard Biesheuvel
@ 2026-08-27  3:50 ` Andrew Morton
  2026-08-27  7:21   ` Geert Uytterhoeven
  2 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2026-08-27  3:50 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Christoph Hellwig, Eric Biggers, Ard Biesheuvel, linux-kselftest,
	linux-kernel, linux-raid

On Mon, 24 Aug 2026 17:14:01 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Enabling the (possibly long-running benchmarks) by default may cause a
> big delay in boot time in case of built-in tests.  However, they can
> still safely be enabled by default if all tests are modular, as they
> would only run when requested explicitly by the system administrator.
> 
> ...
>
> --- a/lib/raid/Kconfig
> +++ b/lib/raid/Kconfig
> @@ -32,6 +32,7 @@ config XOR_KUNIT_TEST
>  config XOR_BENCHMARK
>  	bool "Benchmark for xor_gen"
>  	depends on XOR_KUNIT_TEST
> +	default y if KUNIT_ALL_TESTS=m
>  	help
>  	  Include benchmarks in the KUnit test suite for xor_gen.
>  
> @@ -63,6 +64,7 @@ config RAID6_PQ_KUNIT_TEST
>  config RAID6_PQ_KUNIT_BENCHMARK
>  	bool "Benchmark for RAID6 PQ"
>  	depends on RAID6_PQ_KUNIT_TEST
> +	default y if KUNIT_ALL_TESTS=m
>  	help
>  	  Include benchmarks in the KUnit test suite for raid P/Q generation.

OK, thanks, but...

hp2:/usr/src/mm> scripts/get_maintainer.pl -f --no-rolestats lib/raid
[not linux-raid@vger.kernel.org]

Patches enthusiastically accepted ;)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-27  3:50 ` Andrew Morton
@ 2026-08-27  7:21   ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-08-27  7:21 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Christoph Hellwig, Eric Biggers, Ard Biesheuvel, linux-kselftest,
	linux-kernel, linux-raid

Hi Andrew,

On Thu, 27 Aug 2026 at 05:51, Andrew Morton <akpm@linux-foundation.org> wrote:
> OK, thanks, but...
>
> hp2:/usr/src/mm> scripts/get_maintainer.pl -f --no-rolestats lib/raid
> [not linux-raid@vger.kernel.org]
>
> Patches enthusiastically accepted ;)

At your service
https://lore.kernel.org/7a2e5de234cc0286e3fe9bc11b810433775f2280.1787815121.git.geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-27  7:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
2026-08-25  8:01 ` Christoph Hellwig
2026-08-25  8:32 ` Ard Biesheuvel
2026-08-27  3:50 ` Andrew Morton
2026-08-27  7:21   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®