* [RESEND PATCH] remoteproc: xlnx: do not send new mailbox notification
@ 2026-08-26 17:39 Tanmay Shah
2026-08-27 15:31 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Tanmay Shah @ 2026-08-26 17:39 UTC (permalink / raw)
To: andersson, mathieu.poirier; +Cc: linux-remoteproc, linux-kernel, Tanmay Shah
Only write a new message to the tx mbox queue if slot is available in
the tx queue. If queue is full, then do not send new mbox notification.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
drivers/remoteproc/xlnx_r5_remoteproc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
index c685bb5fa62c..0e71edf8174c 100644
--- a/drivers/remoteproc/xlnx_r5_remoteproc.c
+++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
@@ -381,7 +381,10 @@ static void zynqmp_r5_rproc_kick(struct rproc *rproc, int vqid)
int ret;
ipi = r5_core->ipi;
- if (!ipi)
+ if (!ipi || !ipi->tx_chan)
+ return;
+
+ if (mbox_chan_tx_slots_available(ipi->tx_chan) == 0)
return;
mb_msg = (struct zynqmp_ipi_message *)ipi->tx_mc_buf;
base-commit: d4d61a4b0a52e8f3cdb3e1578602850a3452ec3e
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] remoteproc: xlnx: do not send new mailbox notification
2026-08-26 17:39 [RESEND PATCH] remoteproc: xlnx: do not send new mailbox notification Tanmay Shah
@ 2026-08-27 15:31 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2026-08-27 15:31 UTC (permalink / raw)
To: Tanmay Shah; +Cc: andersson, linux-remoteproc, linux-kernel
On Wed, 26 Aug 2026 at 11:39, Tanmay Shah <tanmay.shah@amd.com> wrote:
>
> Only write a new message to the tx mbox queue if slot is available in
> the tx queue. If queue is full, then do not send new mbox notification.
>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> drivers/remoteproc/xlnx_r5_remoteproc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
We are finally closing the loop on this patchset. I'll pick this up
when RC1 comes out next week.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
> index c685bb5fa62c..0e71edf8174c 100644
> --- a/drivers/remoteproc/xlnx_r5_remoteproc.c
> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
> @@ -381,7 +381,10 @@ static void zynqmp_r5_rproc_kick(struct rproc *rproc, int vqid)
> int ret;
>
> ipi = r5_core->ipi;
> - if (!ipi)
> + if (!ipi || !ipi->tx_chan)
> + return;
> +
> + if (mbox_chan_tx_slots_available(ipi->tx_chan) == 0)
> return;
>
> mb_msg = (struct zynqmp_ipi_message *)ipi->tx_mc_buf;
>
> base-commit: d4d61a4b0a52e8f3cdb3e1578602850a3452ec3e
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-27 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-26 17:39 [RESEND PATCH] remoteproc: xlnx: do not send new mailbox notification Tanmay Shah
2026-08-27 15:31 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®