* [PATCH 5.10] Revert "USB: serial: keyspan_pda: fix information leak"
@ 2026-08-30 14:53 Fedor Pchelkin
2026-09-01 1:21 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Fedor Pchelkin @ 2026-08-30 14:53 UTC (permalink / raw)
To: stable
Cc: Fedor Pchelkin, Sasha Levin, Greg Kroah-Hartman, Johan Hovold,
linux-usb, linux-kernel, lvc-project
This reverts commit cccef1711efbcdbe999738ac27d37b9ef6271abd which is
commit 6bfc8d01ac4068eced509f8fc74d0cd205e4dcec upstream.
The 5.10 backport is incorrect - instead of keyspan_pda_write_start() it
touches the wrong function keyspan_pda_write() which now returns an
incorrect number of buffered bytes.
It turns out that the proper fix for keyspan_pda_write_start() has been
already incorporated into the ported version of upstream commit
034e38e8f687 ("USB: serial: keyspan_pda: add write-fifo support"), for
unknown reason.
Other stable kernels, starting with 5.15, got proper backports.
Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
---
drivers/usb/serial/keyspan_pda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index 21dfd9bdc150..7141660d5d59 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -606,7 +606,7 @@ static int keyspan_pda_write(struct tty_struct *tty, struct usb_serial_port *por
if (rc)
return rc;
- return 0;
+ return count;
}
static void keyspan_pda_dtr_rts(struct usb_serial_port *port, int on)
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 5.10] Revert "USB: serial: keyspan_pda: fix information leak"
2026-08-30 14:53 [PATCH 5.10] Revert "USB: serial: keyspan_pda: fix information leak" Fedor Pchelkin
@ 2026-09-01 1:21 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2026-09-01 1:21 UTC (permalink / raw)
To: stable
Cc: Sasha Levin, Fedor Pchelkin, Greg Kroah-Hartman, Johan Hovold,
linux-usb, linux-kernel, lvc-project
> This reverts commit cccef1711efbcdbe999738ac27d37b9ef6271abd which is
> commit 6bfc8d01ac4068eced509f8fc74d0cd205e4dcec upstream.
>
> The 5.10 backport is incorrect - instead of keyspan_pda_write_start() it
> touches the wrong function keyspan_pda_write() which now returns an
> incorrect number of buffered bytes.
Queued for 5.10, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-01 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-30 14:53 [PATCH 5.10] Revert "USB: serial: keyspan_pda: fix information leak" Fedor Pchelkin
2026-09-01 1:21 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®