From: Priyank Rathod <rathodpriyank@google.com>
To: lukas@wunner.de
Cc: Priyank Rathod <rathodpriyank@google.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Stefan Roese <stefan.roese@mailbox.org>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/AER: Fix struct pci_dev reference leak in aer_process_err_devices()
Date: Mon, 31 Aug 2026 03:24:40 +0000 [thread overview]
Message-ID: <20260831032440.1053206-1-rathodpriyank@google.com> (raw)
In-Reply-To: <apSdOnbdLdrJ7ksF@wunner.de>
On Sun, Aug 30, 2026 at 11:14:34PM +0200, Lukas Wunner wrote:
> The "no active error status is read" is the only scenario where
> this *could* happen. However if no error bits are set in the
> status register, why did the device send an error message upstream
> in the first place? That would be a broken device.
>
> Another theoretical possibility would be that the device becomes
> inaccessible by the time aer_get_device_error_info() reads the
> status/mask registers. They'd both be read as "all ones",
> hence info->status & ~info->mask == 0.
Hi Lukas,
Thanks for the review and clarifying that.
The underlying reference count leak is genuine, but the additional topology
scenarios listed in v1 were inadvertently incorporated from an automated AI
review bot report, which introduced those inaccurate/hallucinated cases.
I have updated this in v2:
- Corrected the Fixes tag to 60271ab044a5 ("PCI/AER: Take reference on error devices").
- Cleaned up the commit description to remove the extra scenarios and focus
strictly on the actual failure path (device becoming inaccessible / register
read returning no active unmasked status).
Thanks,
Priyank
prev parent reply other threads:[~2026-08-31 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 20:28 Priyank Rathod
2026-08-30 21:02 ` Lukas Wunner
2026-08-30 21:14 ` Lukas Wunner
2026-08-31 3:24 ` Priyank Rathod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831032440.1053206-1-rathodpriyank@google.com \
--to=rathodpriyank@google.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=stefan.roese@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®