mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: Yuanhe Shu <xiangzao@linux.alibaba.com>,
	jgg@ziepe.ca, joro@8bytes.org, will@kernel.org,
	robin.murphy@arm.com, baolu.lu@linux.intel.com,
	kevin.tian@intel.com, praan@google.com, skhawaja@google.com,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iommu: Drop IOMMU_DEBUG_PAGEALLOC refs on iommupt domain teardown
Date: Mon, 31 Aug 2026 14:23:33 +0800	[thread overview]
Message-ID: <20260831062335.2177025-1-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <apBgOqEP4Fv6cOaV@google.com>

On Thu, Aug 27, 2026 at 04:05:14PM +0000, Mostafa Saleh wrote:
> Which drivers cause this?

None that I can point to.  The trigger was the generic_pt kunit suite,
which frees domains with live mappings, plus a module I wrote to confirm
the mechanism.  You and Jason are both right that an iommu API user has to
unmap, so the premise of the series was wrong; I am dropping it and fixing
the kunit cases to unmap instead.

And from your reply on 1/2:

> But the IOVA can be calculated when walking the table from freeing
> context or am I missing something?

You weren't missing anything - Jason pointed out the same thing, and no
iova_to_phys() is involved: pts->range->va already holds the IOVA of the
current iteration position.

Thanks,
Yuanhe

      reply	other threads:[~2026-08-31  6:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 14:58 Yuanhe Shu
2026-08-27 14:58 ` [PATCH 1/2] iommu: Add __iommu_debug_unmap_phys() to drop refs by physical address Yuanhe Shu
2026-08-27 16:13   ` Mostafa Saleh
2026-08-27 16:17     ` Mostafa Saleh
2026-08-27 16:21   ` Jason Gunthorpe
2026-08-31  6:21     ` Yuanhe Shu
2026-08-27 14:58 ` [PATCH 2/2] iommupt: Drop pagealloc references during domain deinit Yuanhe Shu
2026-08-27 16:18   ` Jason Gunthorpe
2026-08-31  6:16     ` Yuanhe Shu
2026-08-27 16:05 ` [PATCH 0/2] iommu: Drop IOMMU_DEBUG_PAGEALLOC refs on iommupt domain teardown Mostafa Saleh
2026-08-31  6:23   ` Yuanhe Shu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831062335.2177025-1-xiangzao@linux.alibaba.com \
    --to=xiangzao@linux.alibaba.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=praan@google.com \
    --cc=robin.murphy@arm.com \
    --cc=skhawaja@google.com \
    --cc=smostafa@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®