* [PATCH RESEND] crypto: x86/aria - add missing vzeroupper in AVX-512 code
@ 2026-08-31 21:18 Eric Biggers
2026-09-04 3:41 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2026-08-31 21:18 UTC (permalink / raw)
To: linux-crypto, Herbert Xu
Cc: linux-kernel, x86, Eric Biggers, stable, Taehee Yoo
Since the AVX-512 optimized ARIA code uses ZMM registers, execute
vzeroupper before returning from it. This is needed to avoid degrading
the performance of any later SSE code that may happen to be executed.
Fixes: c970d42001f2 ("crypto: x86/aria - implement aria-avx512")
Cc: stable@vger.kernel.org
Cc: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
This didn't get picked up by the x86 maintainers yet. Herbert, can you
take this through the crypto tree?
arch/x86/crypto/aria-gfni-avx512-asm_64.S | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/crypto/aria-gfni-avx512-asm_64.S b/arch/x86/crypto/aria-gfni-avx512-asm_64.S
index 860887e5d02e..ca83eb126e06 100644
--- a/arch/x86/crypto/aria-gfni-avx512-asm_64.S
+++ b/arch/x86/crypto/aria-gfni-avx512-asm_64.S
@@ -800,6 +800,7 @@ SYM_TYPED_FUNC_START(aria_gfni_avx512_encrypt_64way)
%zmm9, %zmm8, %zmm11, %zmm10, %zmm12, %zmm13, %zmm14,
%zmm15, %rax);
+ vzeroupper;
FRAME_END
RET;
SYM_FUNC_END(aria_gfni_avx512_encrypt_64way)
@@ -825,6 +826,7 @@ SYM_TYPED_FUNC_START(aria_gfni_avx512_decrypt_64way)
%zmm9, %zmm8, %zmm11, %zmm10, %zmm12, %zmm13, %zmm14,
%zmm15, %rax);
+ vzeroupper;
FRAME_END
RET;
SYM_FUNC_END(aria_gfni_avx512_decrypt_64way)
@@ -966,6 +968,7 @@ SYM_TYPED_FUNC_START(aria_gfni_avx512_ctr_crypt_64way)
%zmm9, %zmm8, %zmm11, %zmm10, %zmm12, %zmm13, %zmm14,
%zmm15, %r10);
+ vzeroupper;
FRAME_END
RET;
SYM_FUNC_END(aria_gfni_avx512_ctr_crypt_64way)
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
prerequisite-patch-id: 464c5d2854c73d88ca57d9d6811ae20d6a66c2aa
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH RESEND] crypto: x86/aria - add missing vzeroupper in AVX-512 code
2026-08-31 21:18 [PATCH RESEND] crypto: x86/aria - add missing vzeroupper in AVX-512 code Eric Biggers
@ 2026-09-04 3:41 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-09-04 3:41 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto, linux-kernel, x86, stable, Taehee Yoo
On Mon, Aug 31, 2026 at 02:18:12PM -0700, Eric Biggers wrote:
> Since the AVX-512 optimized ARIA code uses ZMM registers, execute
> vzeroupper before returning from it. This is needed to avoid degrading
> the performance of any later SSE code that may happen to be executed.
>
> Fixes: c970d42001f2 ("crypto: x86/aria - implement aria-avx512")
> Cc: stable@vger.kernel.org
> Cc: Taehee Yoo <ap420073@gmail.com>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This didn't get picked up by the x86 maintainers yet. Herbert, can you
> take this through the crypto tree?
>
> arch/x86/crypto/aria-gfni-avx512-asm_64.S | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-04 3:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-31 21:18 [PATCH RESEND] crypto: x86/aria - add missing vzeroupper in AVX-512 code Eric Biggers
2026-09-04 3:41 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®