* [PATCH] kselftest/arm64: Extend gcs-locking to cover cases where enable is unlocked
@ 2026-09-01 17:27 Mark Brown
2026-10-06 22:56 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2026-09-01 17:27 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Shuah Khan
Cc: Bill Roberts, linux-arm-kernel, linux-kselftest, linux-kernel,
Mark Brown
The gcs-locking test case currently only covers locking combinations of
the various flags that can be set for GCS (enable, write and push) where
enable is included in the locked bits. Since it is valid to only lock a
combination of write and push while leaving enable user controllable we
should also cover those cases, add coverage for them. The new cases pass
as expected.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/arm64/gcs/gcs-locking.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tools/testing/selftests/arm64/gcs/gcs-locking.c b/tools/testing/selftests/arm64/gcs/gcs-locking.c
index 1e6abb136ffd..4dd7ab4191f1 100644
--- a/tools/testing/selftests/arm64/gcs/gcs-locking.c
+++ b/tools/testing/selftests/arm64/gcs/gcs-locking.c
@@ -77,6 +77,21 @@ FIXTURE_VARIANT_ADD(valid_modes, enable_write_push)
PR_SHADOW_STACK_PUSH,
};
+FIXTURE_VARIANT_ADD(valid_modes, write)
+{
+ .mode = PR_SHADOW_STACK_WRITE,
+};
+
+FIXTURE_VARIANT_ADD(valid_modes, push)
+{
+ .mode = PR_SHADOW_STACK_PUSH,
+};
+
+FIXTURE_VARIANT_ADD(valid_modes, write_push)
+{
+ .mode = PR_SHADOW_STACK_WRITE | PR_SHADOW_STACK_PUSH,
+};
+
FIXTURE_SETUP(valid_modes)
{
}
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260826-arm64-test-gcs-locking-no-enable-c291cdcdf083
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kselftest/arm64: Extend gcs-locking to cover cases where enable is unlocked
2026-09-01 17:27 [PATCH] kselftest/arm64: Extend gcs-locking to cover cases where enable is unlocked Mark Brown
@ 2026-10-06 22:56 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2026-10-06 22:56 UTC (permalink / raw)
To: Will Deacon, Shuah Khan, Mark Brown
Cc: Bill Roberts, linux-arm-kernel, linux-kselftest, linux-kernel
On Tue, 01 Sep 2026 18:27:06 +0100, Mark Brown wrote:
> The gcs-locking test case currently only covers locking combinations of
> the various flags that can be set for GCS (enable, write and push) where
> enable is included in the locked bits. Since it is valid to only lock a
> combination of write and push while leaving enable user controllable we
> should also cover those cases, add coverage for them. The new cases pass
> as expected.
>
> [...]
Applied to arm64 (for-next/kselftest), thanks!
[1/1] kselftest/arm64: Extend gcs-locking to cover cases where enable is unlocked
https://git.kernel.org/arm64/c/a3fcb14f5673
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-06 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-01 17:27 [PATCH] kselftest/arm64: Extend gcs-locking to cover cases where enable is unlocked Mark Brown
2026-10-06 22:56 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®