* [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052
@ 2026-08-31 20:15 Frank.Li
2026-09-01 17:00 ` Conor Dooley
2026-09-03 9:58 ` Krzysztof Kozlowski
0 siblings, 2 replies; 12+ messages in thread
From: Frank.Li @ 2026-08-31 20:15 UTC (permalink / raw)
To: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
From: Frank Li <Frank.Li@nxp.com>
Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10
years) check_dtbs warnings:
arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long
from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Previous try drop dlg,da9052 at
https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
but Krzy have concern about compablity.
https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/
Conor prefer update old dts.
---
Documentation/devicetree/bindings/mfd/dlg,da9052.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
index 1103a8cc5cea4..d1d23c7c4d0c2 100644
--- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
+++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
@@ -18,6 +18,10 @@ properties:
- dlg,da9053-bb
- dlg,da9053-bc
- dlg,da9052
+ - items:
+ - enum:
+ - dlg,da9053-aa
+ - const: dlg,da9052
reg:
maxItems: 1
--
2.43.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-08-31 20:15 [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 Frank.Li @ 2026-09-01 17:00 ` Conor Dooley 2026-09-02 10:25 ` Lee Jones 2026-09-03 10:04 ` Krzysztof Kozlowski 2026-09-03 9:58 ` Krzysztof Kozlowski 1 sibling, 2 replies; 12+ messages in thread From: Conor Dooley @ 2026-09-01 17:00 UTC (permalink / raw) To: Frank.Li Cc: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx [-- Attachment #1: Type: text/plain, Size: 1939 bytes --] On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li <Frank.Li@nxp.com> > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > years) check_dtbs warnings: > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Previous try drop dlg,da9052 at > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > but Krzy have concern about compablity. > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > Conor prefer update old dts. I don't think these devices are actually compatible, so this fallback would be wrong. The data comes from the match data, be that spi or i2c, and there's explicitly different behaviour for the da9052 and da9053aa. I doubt the legacy platform ever worked properly, and this is what should have been explained in the PR that Krzysztof denied not just blindly citing a dtbs_check problem. Nacked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/mfd/dlg,da9052.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > index 1103a8cc5cea4..d1d23c7c4d0c2 100644 > --- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > @@ -18,6 +18,10 @@ properties: > - dlg,da9053-bb > - dlg,da9053-bc > - dlg,da9052 > + - items: > + - enum: > + - dlg,da9053-aa > + - const: dlg,da9052 > > reg: > maxItems: 1 > -- > 2.43.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-01 17:00 ` Conor Dooley @ 2026-09-02 10:25 ` Lee Jones 2026-09-02 17:01 ` Conor Dooley 2026-09-03 10:04 ` Krzysztof Kozlowski 1 sibling, 1 reply; 12+ messages in thread From: Lee Jones @ 2026-09-02 10:25 UTC (permalink / raw) To: Conor Dooley Cc: Frank.Li, Support Opensource, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Tue, 01 Sep 2026, Conor Dooley wrote: > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > From: Frank Li <Frank.Li@nxp.com> > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > years) check_dtbs warnings: > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Previous try drop dlg,da9052 at > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > but Krzy have concern about compablity. > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > Conor prefer update old dts. > > I don't think these devices are actually compatible, so this fallback > would be wrong. > The data comes from the match data, be that spi or i2c, and there's > explicitly different behaviour for the da9052 and da9053aa. > I doubt the legacy platform ever worked properly, and this is what should > have been explained in the PR that Krzysztof denied not just blindly > citing a dtbs_check problem. > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> At first glance this looks like an Acked-by. IMHO, this is going to cause issues - please rethink this. -- Lee Jones ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-02 10:25 ` Lee Jones @ 2026-09-02 17:01 ` Conor Dooley 2026-09-03 9:06 ` Lee Jones 0 siblings, 1 reply; 12+ messages in thread From: Conor Dooley @ 2026-09-02 17:01 UTC (permalink / raw) To: Lee Jones Cc: Frank.Li, Support Opensource, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx [-- Attachment #1: Type: text/plain, Size: 1690 bytes --] On Wed, Sep 02, 2026 at 11:25:32AM +0100, Lee Jones wrote: > On Tue, 01 Sep 2026, Conor Dooley wrote: > > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > years) check_dtbs warnings: > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > Previous try drop dlg,da9052 at > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > but Krzy have concern about compablity. > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > Conor prefer update old dts. > > > > I don't think these devices are actually compatible, so this fallback > > would be wrong. > > The data comes from the match data, be that spi or i2c, and there's > > explicitly different behaviour for the da9052 and da9053aa. > > I doubt the legacy platform ever worked properly, and this is what should > > have been explained in the PR that Krzysztof denied not just blindly > > citing a dtbs_check problem. > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > At first glance this looks like an Acked-by. > > IMHO, this is going to cause issues - please rethink this. As in, use NAKed-by instead or just say NAK without the name/mail? Not entirely sure what you're getting at. Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-02 17:01 ` Conor Dooley @ 2026-09-03 9:06 ` Lee Jones 2026-09-03 10:06 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Lee Jones @ 2026-09-03 9:06 UTC (permalink / raw) To: Conor Dooley Cc: Frank.Li, Support Opensource, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Wed, 02 Sep 2026, Conor Dooley wrote: > On Wed, Sep 02, 2026 at 11:25:32AM +0100, Lee Jones wrote: > > On Tue, 01 Sep 2026, Conor Dooley wrote: > > > > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > > years) check_dtbs warnings: > > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > Previous try drop dlg,da9052 at > > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > > > but Krzy have concern about compablity. > > > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > > > Conor prefer update old dts. > > > > > > I don't think these devices are actually compatible, so this fallback > > > would be wrong. > > > The data comes from the match data, be that spi or i2c, and there's > > > explicitly different behaviour for the da9052 and da9053aa. > > > I doubt the legacy platform ever worked properly, and this is what should > > > have been explained in the PR that Krzysztof denied not just blindly > > > citing a dtbs_check problem. > > > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > > > At first glance this looks like an Acked-by. > > > > IMHO, this is going to cause issues - please rethink this. > > As in, use NAKed-by instead or just say NAK without the name/mail? > Not entirely sure what you're getting at. As in, don't make NACKs looks like acceptance trailers. If you're going to "NACK", which I always felt was a bit harsh anyway, just say it without making it appear like an official sign-off. Please. -- Lee Jones ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-03 9:06 ` Lee Jones @ 2026-09-03 10:06 ` Krzysztof Kozlowski 2026-09-03 11:36 ` Lee Jones 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-09-03 10:06 UTC (permalink / raw) To: Lee Jones Cc: Conor Dooley, Frank.Li, Support Opensource, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Sep 03, 2026 at 10:06:25AM +0100, Lee Jones wrote: > On Wed, 02 Sep 2026, Conor Dooley wrote: > > > On Wed, Sep 02, 2026 at 11:25:32AM +0100, Lee Jones wrote: > > > On Tue, 01 Sep 2026, Conor Dooley wrote: > > > > > > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > > > years) check_dtbs warnings: > > > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > > --- > > > > > Previous try drop dlg,da9052 at > > > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > > > > > but Krzy have concern about compablity. > > > > > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > > > > > Conor prefer update old dts. > > > > > > > > I don't think these devices are actually compatible, so this fallback > > > > would be wrong. > > > > The data comes from the match data, be that spi or i2c, and there's > > > > explicitly different behaviour for the da9052 and da9053aa. > > > > I doubt the legacy platform ever worked properly, and this is what should > > > > have been explained in the PR that Krzysztof denied not just blindly > > > > citing a dtbs_check problem. > > > > > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > At first glance this looks like an Acked-by. > > > > > > IMHO, this is going to cause issues - please rethink this. > > > > As in, use NAKed-by instead or just say NAK without the name/mail? > > Not entirely sure what you're getting at. > > As in, don't make NACKs looks like acceptance trailers. > > If you're going to "NACK", which I always felt was a bit harsh anyway, > just say it without making it appear like an official sign-off. Please. Heh, tag is correct if maintainer, e.g. you in this case, would like to take such patch still. There were already such cases, I did it once as well to express that I do not agree with the approach taken by other maintainer and I want to be sure that a commit in git history will never be used in future discussions against my review (because this happens all the time "I found commit like this, so I can add here poor code"). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-03 10:06 ` Krzysztof Kozlowski @ 2026-09-03 11:36 ` Lee Jones 0 siblings, 0 replies; 12+ messages in thread From: Lee Jones @ 2026-09-03 11:36 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Conor Dooley, Frank.Li, Support Opensource, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, 03 Sep 2026, Krzysztof Kozlowski wrote: > On Thu, Sep 03, 2026 at 10:06:25AM +0100, Lee Jones wrote: > > On Wed, 02 Sep 2026, Conor Dooley wrote: > > > > > On Wed, Sep 02, 2026 at 11:25:32AM +0100, Lee Jones wrote: > > > > On Tue, 01 Sep 2026, Conor Dooley wrote: > > > > > > > > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > > > > years) check_dtbs warnings: > > > > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > > > --- > > > > > > Previous try drop dlg,da9052 at > > > > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > > > > > > > but Krzy have concern about compablity. > > > > > > > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > > > > > > > Conor prefer update old dts. > > > > > > > > > > I don't think these devices are actually compatible, so this fallback > > > > > would be wrong. > > > > > The data comes from the match data, be that spi or i2c, and there's > > > > > explicitly different behaviour for the da9052 and da9053aa. > > > > > I doubt the legacy platform ever worked properly, and this is what should > > > > > have been explained in the PR that Krzysztof denied not just blindly > > > > > citing a dtbs_check problem. > > > > > > > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > At first glance this looks like an Acked-by. > > > > > > > > IMHO, this is going to cause issues - please rethink this. > > > > > > As in, use NAKed-by instead or just say NAK without the name/mail? > > > Not entirely sure what you're getting at. > > > > As in, don't make NACKs looks like acceptance trailers. > > > > If you're going to "NACK", which I always felt was a bit harsh anyway, > > just say it without making it appear like an official sign-off. Please. > > Heh, tag is correct if maintainer, e.g. you in this case, would like to > take such patch still. There were already such cases, I did it once as > well to express that I do not agree with the approach taken by other > maintainer and I want to be sure that a commit in git history will never > be used in future discussions against my review (because this happens > all the time "I found commit like this, so I can add here poor code"). I wouldn't take the patch if it was NACKed. -- Lee Jones ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-01 17:00 ` Conor Dooley 2026-09-02 10:25 ` Lee Jones @ 2026-09-03 10:04 ` Krzysztof Kozlowski 2026-09-03 15:34 ` Conor Dooley 2026-09-03 19:15 ` Frank Li 1 sibling, 2 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-09-03 10:04 UTC (permalink / raw) To: Conor Dooley Cc: Frank.Li, Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Tue, Sep 01, 2026 at 06:00:31PM +0100, Conor Dooley wrote: > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > From: Frank Li <Frank.Li@nxp.com> > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > years) check_dtbs warnings: > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Previous try drop dlg,da9052 at > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > but Krzy have concern about compablity. > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > Conor prefer update old dts. > > I don't think these devices are actually compatible, so this fallback > would be wrong. > The data comes from the match data, be that spi or i2c, and there's > explicitly different behaviour for the da9052 and da9053aa. Maybe I looked at wrong driver, where is the difference? I made a very quick glance and I found the only difference in da9052_i2c_fix(): 59 switch (da9052->chip_id) { 60 case DA9052: 61 case DA9053_AA: 62 case DA9053_BA: 63 case DA9053_BB: No differences in "da9052-core.c" and SPI, while looking for these device type enum values. > I doubt the legacy platform ever worked properly, and this is what should > have been explained in the PR that Krzysztof denied not just blindly > citing a dtbs_check problem. Well, yeah, I wanted an accurate reason with actual analysis, not necessarily making devices compatible if they are not. > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-03 10:04 ` Krzysztof Kozlowski @ 2026-09-03 15:34 ` Conor Dooley 2026-09-03 19:15 ` Frank Li 1 sibling, 0 replies; 12+ messages in thread From: Conor Dooley @ 2026-09-03 15:34 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Frank.Li, Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx [-- Attachment #1: Type: text/plain, Size: 2285 bytes --] On Thu, Sep 03, 2026 at 12:04:42PM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 01, 2026 at 06:00:31PM +0100, Conor Dooley wrote: > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > years) check_dtbs warnings: > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > Previous try drop dlg,da9052 at > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > but Krzy have concern about compablity. > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > Conor prefer update old dts. > > > > I don't think these devices are actually compatible, so this fallback > > would be wrong. > > The data comes from the match data, be that spi or i2c, and there's > > explicitly different behaviour for the da9052 and da9053aa. > > Maybe I looked at wrong driver, where is the difference? I made a very > quick glance and I found the only difference in da9052_i2c_fix(): > > 59 switch (da9052->chip_id) { > 60 case DA9052: > 61 case DA9053_AA: > 62 case DA9053_BA: > 63 case DA9053_BB: > > No differences in "da9052-core.c" and SPI, while looking for these > device type enum values. If you look further afield, since this is an mfd, in the regulator driver there's a lot of conditions there that depend on the chip_id. E.g. current limits and voltage steps differ. There's also one in the battery driver. > > I doubt the legacy platform ever worked properly, and this is what should > > have been explained in the PR that Krzysztof denied not just blindly > > citing a dtbs_check problem. > > Well, yeah, I wanted an accurate reason with actual analysis, not > necessarily making devices compatible if they are not. > > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > Best regards, > Krzysztof > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-03 10:04 ` Krzysztof Kozlowski 2026-09-03 15:34 ` Conor Dooley @ 2026-09-03 19:15 ` Frank Li 1 sibling, 0 replies; 12+ messages in thread From: Frank Li @ 2026-09-03 19:15 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Conor Dooley, Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Sep 03, 2026 at 12:04:42PM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 01, 2026 at 06:00:31PM +0100, Conor Dooley wrote: > > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > > From: Frank Li <Frank.Li@nxp.com> > > > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > > years) check_dtbs warnings: > > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > Previous try drop dlg,da9052 at > > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > > > but Krzy have concern about compablity. > > > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > > > Conor prefer update old dts. > > > > I don't think these devices are actually compatible, so this fallback > > would be wrong. > > The data comes from the match data, be that spi or i2c, and there's > > explicitly different behaviour for the da9052 and da9053aa. > > Maybe I looked at wrong driver, where is the difference? I made a very > quick glance and I found the only difference in da9052_i2c_fix(): > > 59 switch (da9052->chip_id) { > 60 case DA9052: > 61 case DA9053_AA: > 62 case DA9053_BA: > 63 case DA9053_BB: > > No differences in "da9052-core.c" and SPI, while looking for these > device type enum values. It is mfd, probe child device, like da9052-regulator.c DA9052 vs DA9053-AA Differences (from da9052-regulator.c) 1. BUCK4 Voltage Range (only regulator table difference) DA9052 BUCK4 DA9053-AA BUCK4 Min voltage 1800 mV 950 mV Max voltage 3600 mV 2525 mV Step size 50 mV 25 mV DA9052 BUCK4 also has a non-linear voltage mapping above 3V (step increases to 100 mV for selector >= 24). DA9053-AA BUCK4 has no such special mapping. 2. BUCK Current Limits Level DA9052 (all BUCKs) DA9053-AA BUCK1 DA9053-AA BUCK2/3/4 0 700 mA 1600 mA 800 mA 1 800 mA 2000 mA 1000 mA 2 1000 mA 2400 mA 1200 mA 3 1200 mA 3000 mA 1500 mA DA9053-AA BUCK1 supports up to 3A (vs 1.2A on DA9052). Frank > > > I doubt the legacy platform ever worked properly, and this is what should > > have been explained in the PR that Krzysztof denied not just blindly > > citing a dtbs_check problem. > > Well, yeah, I wanted an accurate reason with actual analysis, not > necessarily making devices compatible if they are not. > > > > > Nacked-by: Conor Dooley <conor.dooley@microchip.com> > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-08-31 20:15 [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 Frank.Li 2026-09-01 17:00 ` Conor Dooley @ 2026-09-03 9:58 ` Krzysztof Kozlowski 2026-09-03 19:22 ` Frank Li 1 sibling, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-09-03 9:58 UTC (permalink / raw) To: Frank.Li Cc: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li <Frank.Li@nxp.com> > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > years) check_dtbs warnings: > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Previous try drop dlg,da9052 at > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > but Krzy have concern about compablity. > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > Conor prefer update old dts. > --- > Documentation/devicetree/bindings/mfd/dlg,da9052.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > index 1103a8cc5cea4..d1d23c7c4d0c2 100644 > --- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > @@ -18,6 +18,10 @@ properties: > - dlg,da9053-bb > - dlg,da9053-bc > - dlg,da9052 > + - items: > + - enum: > + - dlg,da9053-aa > + - const: dlg,da9052 ... and the dlg,da9053-aa alone from earlier enum should be removed and existing DTS corrected. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 2026-09-03 9:58 ` Krzysztof Kozlowski @ 2026-09-03 19:22 ` Frank Li 0 siblings, 0 replies; 12+ messages in thread From: Frank Li @ 2026-09-03 19:22 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Support Opensource, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li, open list:MULTIFUNCTION DEVICES (MFD), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Sep 03, 2026 at 11:58:35AM +0200, Krzysztof Kozlowski wrote: > On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote: > > From: Frank Li <Frank.Li@nxp.com> > > > > Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10 > > years) check_dtbs warnings: > > arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long > > from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Previous try drop dlg,da9052 at > > https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/ > > > > but Krzy have concern about compablity. > > > > https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/ > > > > Conor prefer update old dts. > > --- > > Documentation/devicetree/bindings/mfd/dlg,da9052.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > > index 1103a8cc5cea4..d1d23c7c4d0c2 100644 > > --- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml > > @@ -18,6 +18,10 @@ properties: > > - dlg,da9053-bb > > - dlg,da9053-bc > > - dlg,da9052 > > + - items: > > + - enum: > > + - dlg,da9053-aa > > + - const: dlg,da9052 > > ... and the dlg,da9053-aa alone from earlier enum should be removed and > existing DTS corrected. there are dlg,da9053-aa alone at arch/arm/boot/dts/nxp/imx/imx53-ppd.dts. Mix use both because it is too old. Frank > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2026-09-03 19:22 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-08-31 20:15 [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052 Frank.Li 2026-09-01 17:00 ` Conor Dooley 2026-09-02 10:25 ` Lee Jones 2026-09-02 17:01 ` Conor Dooley 2026-09-03 9:06 ` Lee Jones 2026-09-03 10:06 ` Krzysztof Kozlowski 2026-09-03 11:36 ` Lee Jones 2026-09-03 10:04 ` Krzysztof Kozlowski 2026-09-03 15:34 ` Conor Dooley 2026-09-03 19:15 ` Frank Li 2026-09-03 9:58 ` Krzysztof Kozlowski 2026-09-03 19:22 ` Frank Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®