* [PATCH v3] media: v4l2-h264: Fix memcmp() size in B1 reference list comparison
@ 2026-09-01 2:23 Haotian Zhang
2026-09-02 13:36 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Haotian Zhang @ 2026-09-01 2:23 UTC (permalink / raw)
To: mchehab, nicolas
Cc: boris.brezillon, linux-media, linux-kernel, Haotian Zhang
In v4l2_h264_build_b_ref_lists(), the B0/B1 list equality
check passes the entry count builder->num_valid to memcmp()
instead of a byte size. Since struct v4l2_h264_reference is
two bytes (fields and index), only half of each list is
compared, so distinct lists can be wrongly treated as equal
and trigger an incorrect swap(b1_reflist[0], b1_reflist[1]).
Change the memcmp() size argument to sizeof(b1_reflist[0]) *
builder->num_valid so that the full byte length of both
reference lists is compared.
Fixes: 624922a2739b ("media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists")
Suggested-by: Nicolas Dufresne <nicolas@ndufresne.ca>
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
Changes in v2:
- Use sizeof(b1_reflist[0]) * builder->num_valid for the memcmp() size to
match the style of the memcpy() calls in the same function.
Changes in v3:
- Fix an extra closing parenthesis.
---
drivers/media/v4l2-core/v4l2-h264.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
index c00197d095e7..2323f559c6a3 100644
--- a/drivers/media/v4l2-core/v4l2-h264.c
+++ b/drivers/media/v4l2-core/v4l2-h264.c
@@ -440,7 +440,8 @@ v4l2_h264_build_b_ref_lists(const struct v4l2_h264_reflist_builder *builder,
}
if (builder->num_valid > 1 &&
- !memcmp(b1_reflist, b0_reflist, builder->num_valid))
+ !memcmp(b1_reflist, b0_reflist,
+ sizeof(b1_reflist[0]) * builder->num_valid))
swap(b1_reflist[0], b1_reflist[1]);
print_ref_list_b(builder, b0_reflist, 0);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] media: v4l2-h264: Fix memcmp() size in B1 reference list comparison
2026-09-01 2:23 [PATCH v3] media: v4l2-h264: Fix memcmp() size in B1 reference list comparison Haotian Zhang
@ 2026-09-02 13:36 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2026-09-02 13:36 UTC (permalink / raw)
To: Haotian Zhang, mchehab; +Cc: boris.brezillon, linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
Le mardi 01 septembre 2026 à 10:23 +0800, Haotian Zhang a écrit :
> In v4l2_h264_build_b_ref_lists(), the B0/B1 list equality
> check passes the entry count builder->num_valid to memcmp()
> instead of a byte size. Since struct v4l2_h264_reference is
> two bytes (fields and index), only half of each list is
> compared, so distinct lists can be wrongly treated as equal
> and trigger an incorrect swap(b1_reflist[0], b1_reflist[1]).
>
> Change the memcmp() size argument to sizeof(b1_reflist[0]) *
> builder->num_valid so that the full byte length of both
> reference lists is compared.
>
> Fixes: 624922a2739b ("media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists")
> Suggested-by: Nicolas Dufresne <nicolas@ndufresne.ca>
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> Changes in v2:
> - Use sizeof(b1_reflist[0]) * builder->num_valid for the memcmp() size to
> match the style of the memcpy() calls in the same function.
> Changes in v3:
> - Fix an extra closing parenthesis.
> ---
> drivers/media/v4l2-core/v4l2-h264.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
> index c00197d095e7..2323f559c6a3 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -440,7 +440,8 @@ v4l2_h264_build_b_ref_lists(const struct v4l2_h264_reflist_builder *builder,
> }
>
> if (builder->num_valid > 1 &&
> - !memcmp(b1_reflist, b0_reflist, builder->num_valid))
> + !memcmp(b1_reflist, b0_reflist,
> + sizeof(b1_reflist[0]) * builder->num_valid))
> swap(b1_reflist[0], b1_reflist[1]);
>
> print_ref_list_b(builder, b0_reflist, 0);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-02 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-01 2:23 [PATCH v3] media: v4l2-h264: Fix memcmp() size in B1 reference list comparison Haotian Zhang
2026-09-02 13:36 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®