mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sven Peter <sven@kernel.org>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <westeri@kernel.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Konrad Dybcio <konradybcio@kernel.org>,
	asahi@lists.linux.dev, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 0/7] thunderbolt: Fix DP tunnel teardown while an async DPRX read is running
Date: Tue, 1 Sep 2026 10:19:24 +0200	[thread overview]
Message-ID: <20260901081924.GA106095@black.igk.intel.com> (raw)
In-Reply-To: <20260829-b4-tbt-fixes-v3-0-e1fab6ac54fe@kernel.org>

Hi,

On Sat, Aug 29, 2026 at 10:08:32AM +0200, Sven Peter wrote:
> Hi,
> 
> This series contains a bunch of fixes related to teardown while an async
> DPRX read is running. I ran into some of these while bringing up the
> Apple Silicon NHI and just haven't implemented DP tunneling support yet
> such that the DPRX capabilities read can never complete and will always
> time out.
> 
> None of it is specific to that hardware though so I figured it
> makes sense to already send them out.
> 
> Best,
> 
> Sven
> 
> ---
> Changes in v3:
> - Take the router references in the HopID allocation/release helpers
> - Actually call put_device() via a cleanup action for the KUnit tests
> - Link to v2: https://patch.msgid.link/20260823-b4-tbt-fixes-v2-0-26a18a426c9f@kernel.org
> 
> Changes in v2:
> - Make the DP tunnel activation callback mandatory. The DPRX
>   caps are now always read inside dprx_work which now also happens to
>   discovered tunnels when they are activated again after hibernation
>   restore.
> - Mark discovered tunnels as active
> - Add a cleanup commit to drop the callback data that's always the same now
> - Tear down DP tunnels that are inactive in tb_stop instead of
>   exposing tb_tunnel_cancel_dprx.
> - Use "router" instead of "switch" in the subject
> - Added comments how these issues can be reproduced
> - Link to v1: https://patch.msgid.link/20260817-b4-tbt-fixes-v1-0-eded2461f5fc@kernel.org
> 
> To: Andreas Noever <andreas.noever@gmail.com>
> To: Mika Westerberg <westeri@kernel.org>
> To: Yehezkel Bernat <YehezkelShB@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Konrad Dybcio <konradybcio@kernel.org>
> Cc: asahi@lists.linux.dev
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> ---
> Sven Peter (7):
>       thunderbolt: Hold a router reference for each allocated HopID
>       thunderbolt: Make the DP tunnel activation callback mandatory
>       thunderbolt: Fix domain reference leak when DPRX read is canceled
>       thunderbolt: Don't access a DP tunnel after its DPRX read was canceled
>       thunderbolt: Mark discovered tunnels as active
>       thunderbolt: Tear down inactive DP tunnels when the domain is stopped

Applied 1-6 to thunderbolt.git/fixes, with minor changes in the commit
messages and the condition in patch 6, thanks! Please check that it is
okay. My testing at least it works as expected.

>       thunderbolt: Drop the DP tunnel activation callback data

Since this one is a cleanup, I wonder if you can send it again later when
the DPRX fixes have landed? I typically base my next branch after -rc1 and
don't merge fixes/rc's there constantly so preferably after v7.4-rc1 is
released.

  parent reply	other threads:[~2026-09-01  8:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29  8:08 Sven Peter
2026-08-29  8:08 ` [PATCH v3 1/7] thunderbolt: Hold a router reference for each allocated HopID Sven Peter
2026-08-29  8:08 ` [PATCH v3 2/7] thunderbolt: Make the DP tunnel activation callback mandatory Sven Peter
2026-08-29  8:08 ` [PATCH v3 3/7] thunderbolt: Fix domain reference leak when DPRX read is canceled Sven Peter
2026-08-29  8:08 ` [PATCH v3 4/7] thunderbolt: Don't access a DP tunnel after its DPRX read was canceled Sven Peter
2026-08-29  8:08 ` [PATCH v3 5/7] thunderbolt: Mark discovered tunnels as active Sven Peter
2026-08-29  8:08 ` [PATCH v3 6/7] thunderbolt: Tear down inactive DP tunnels when the domain is stopped Sven Peter
2026-08-29  8:08 ` [PATCH v3 7/7] thunderbolt: Drop the DP tunnel activation callback data Sven Peter
2026-09-01  8:19 ` Mika Westerberg [this message]
2026-09-01  8:53   ` [PATCH v3 0/7] thunderbolt: Fix DP tunnel teardown while an async DPRX read is running Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901081924.GA106095@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=asahi@lists.linux.dev \
    --cc=konradybcio@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sven@kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®