From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Yuanhe Shu <xiangzao@linux.alibaba.com>,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
xin@zytor.com, luto@kernel.org, jpoimboe@kernel.org,
peterz@infradead.org, rostedt@goodmis.org,
akpm@linux-foundation.org, rdunlap@infradead.org,
elver@google.com, andreyknvl@gmail.com, glider@google.com,
gor@linux.ibm.com, brads@mainlining.org,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] stacktrace: Provide arch_in_event_entry_text() hook
Date: Tue, 1 Sep 2026 20:29:49 +0800 [thread overview]
Message-ID: <20260901122951.1077081-1-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <8c86db41-9270-42c5-b2db-133865d254f7@intel.com>
On Mon, Aug 31, 2026 at 07:01:52AM -0700, Dave Hansen wrote:
> As much as I love inflicting x86-isms on generic comments, I don't think
> this comment needs to talk about x86. I find the most useful generic
> definitions to be like an instruction manual for future arch/
> maintainers. Maybe something like:
[...]
> ... and then talk about why x86 needs it in the x86 definition.
Good point, v3 will do it that way. The x86 definition already says why
the range is needed there and that it covers the ring 3 entry point, so I
will move the note about not being able to tell interrupt entry and
syscall entry apart into that comment as well.
Thanks,
Yuanhe
next prev parent reply other threads:[~2026-09-01 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 12:02 [PATCH v2 0/2] x86/fred: Fix stack depot exhaustion on FRED systems Yuanhe Shu
2026-08-31 12:02 ` [PATCH v2 1/2] stacktrace: Provide arch_in_event_entry_text() hook Yuanhe Shu
2026-08-31 14:01 ` Dave Hansen
2026-09-01 12:29 ` Yuanhe Shu [this message]
2026-08-31 12:02 ` [PATCH v2 2/2] x86/fred: Fix stack depot filtering of FRED event stacks Yuanhe Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901122951.1077081-1-xiangzao@linux.alibaba.com \
--to=xiangzao@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bp@alien8.de \
--cc=brads@mainlining.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®