From: Dave Hansen <dave.hansen@intel.com>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, xin@zytor.com, luto@kernel.org,
jpoimboe@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
akpm@linux-foundation.org, rdunlap@infradead.org,
elver@google.com, andreyknvl@gmail.com, glider@google.com,
gor@linux.ibm.com, brads@mainlining.org,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] stacktrace: Provide arch_in_event_entry_text() hook
Date: Mon, 31 Aug 2026 07:01:52 -0700 [thread overview]
Message-ID: <8c86db41-9270-42c5-b2db-133865d254f7@intel.com> (raw)
In-Reply-To: <20260831120221.2874445-2-xiangzao@linux.alibaba.com>
On 8/31/26 05:02, Yuanhe Shu wrote:
> +/*
> + * Optional arch hook for event entry text which cannot be placed in
> + * .irqentry.text. filter_irq_stacks() uses this and the section checks
> + * below to find where a trace entered the kernel, so the ranges are not
> + * necessarily irq-only: on x86 they also cover the exception entry stubs,
> + * and an architecture may deliver syscalls through the same entry text.
> + * A caller that has to tell interrupt entry and syscall entry apart
> + * cannot use this. An architecture overrides it by defining a macro of
> + * the same name in <asm/sections.h>, next to the markers it tests.
> + */
> +#ifndef arch_in_event_entry_text
> +static inline bool arch_in_event_entry_text(unsigned long addr) { return false; }
> +#endif
As much as I love inflicting x86-isms on generic comments, I don't think
this comment needs to talk about x86. I find the most useful generic
definitions to be like an instruction manual for future arch/
maintainers. Maybe something like:
/*
* Used to help find where a trace entered the kernel.
*
* Architectures use this when event entry text cannot be placed in
* .irqentry.text alone. Architectures should define their
* version in <asm/sections.h>.
*/
... and then talk about why x86 needs it in the x86 definition.
next prev parent reply other threads:[~2026-08-31 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 12:02 [PATCH v2 0/2] x86/fred: Fix stack depot exhaustion on FRED systems Yuanhe Shu
2026-08-31 12:02 ` [PATCH v2 1/2] stacktrace: Provide arch_in_event_entry_text() hook Yuanhe Shu
2026-08-31 14:01 ` Dave Hansen [this message]
2026-09-01 12:29 ` Yuanhe Shu
2026-08-31 12:02 ` [PATCH v2 2/2] x86/fred: Fix stack depot filtering of FRED event stacks Yuanhe Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c86db41-9270-42c5-b2db-133865d254f7@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bp@alien8.de \
--cc=brads@mainlining.org \
--cc=dave.hansen@linux.intel.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xiangzao@linux.alibaba.com \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®