mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: twl4030: Fix "ti,hs_extmute" property type
@ 2026-09-01 15:28 Rob Herring (Arm)
  2026-09-01 18:58 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2026-09-01 15:28 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: linux-sound, linux-kernel

The "ti,hs_extmute" property is a boolean, so use of_property_read_bool()
rather than of_property_read_u32() to read it.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
 - Split to separate patch
 - Assign the value directly from of_property_read_bool() return
---
 sound/soc/codecs/twl4030.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 9476cdfd4dde..b11ba908ba9f 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -202,13 +202,10 @@ static void
 twl4030_get_board_param_values(struct twl4030_board_params *board_params,
 			       struct device_node *node)
 {
-	int value;
-
 	of_property_read_u32(node, "ti,digimic_delay", &board_params->digimic_delay);
 	of_property_read_u32(node, "ti,ramp_delay_value", &board_params->ramp_delay_value);
 	of_property_read_u32(node, "ti,offset_cncl_path", &board_params->offset_cncl_path);
-	if (!of_property_read_u32(node, "ti,hs_extmute", &value))
-		board_params->hs_extmute = value;
+	board_params->hs_extmute = of_property_read_bool(node, "ti,hs_extmute");
 
 	if (of_property_present(node, "ti,hs_extmute_gpio"))
 		board_params->hs_extmute = 1;
-- 
2.53.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ASoC: twl4030: Fix "ti,hs_extmute" property type
  2026-09-01 15:28 [PATCH v2] ASoC: twl4030: Fix "ti,hs_extmute" property type Rob Herring (Arm)
@ 2026-09-01 18:58 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-09-01 18:58 UTC (permalink / raw)
  To: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Rob Herring (Arm)
  Cc: linux-sound, linux-kernel

On Tue, 01 Sep 2026 10:28:55 -0500, Rob Herring (Arm) wrote:
> ASoC: twl4030: Fix "ti,hs_extmute" property type

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: twl4030: Fix "ti,hs_extmute" property type
      https://git.kernel.org/broonie/sound/c/29a88f0d6c74

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-01 22:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-01 15:28 [PATCH v2] ASoC: twl4030: Fix "ti,hs_extmute" property type Rob Herring (Arm)
2026-09-01 18:58 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®