* [PATCH] staging: rtl8723bs: use strscpy() for ifname copy
@ 2026-08-26 14:34 Svyatoslav Nikolenko
2026-09-01 10:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Svyatoslav Nikolenko @ 2026-08-26 14:34 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Svyatoslav Nikolenko
Replace snprintf() with strscpy() when copying ifname into registry_par
to avoid unnecessary format specifier parsing.
Signed-off-by: Svyatoslav Nikolenko <nsvatoslav515@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..dd0c5fc813c8 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -256,7 +256,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
registry_par->enable80211d = (u8)rtw_80211d;
- snprintf(registry_par->ifname, 16, "%s", ifname);
+ strscpy(registry_par->ifname, ifname, sizeof(registry_par->ifname));
registry_par->notch_filter = (u8)rtw_notch_filter;
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: use strscpy() for ifname copy
2026-08-26 14:34 [PATCH] staging: rtl8723bs: use strscpy() for ifname copy Svyatoslav Nikolenko
@ 2026-09-01 10:09 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-09-01 10:09 UTC (permalink / raw)
To: Svyatoslav Nikolenko; +Cc: linux-staging, linux-kernel
On Wed, Aug 26, 2026 at 05:34:18PM +0300, Svyatoslav Nikolenko wrote:
> Replace snprintf() with strscpy() when copying ifname into registry_par
> to avoid unnecessary format specifier parsing.
>
> Signed-off-by: Svyatoslav Nikolenko <nsvatoslav515@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index f31196f54b3e..dd0c5fc813c8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -256,7 +256,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
>
> registry_par->enable80211d = (u8)rtw_80211d;
>
> - snprintf(registry_par->ifname, 16, "%s", ifname);
> + strscpy(registry_par->ifname, ifname, sizeof(registry_par->ifname));
>
> registry_par->notch_filter = (u8)rtw_notch_filter;
the ifname module option, and field, should just be removed from this
driver entirely. Can you do that instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-01 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-26 14:34 [PATCH] staging: rtl8723bs: use strscpy() for ifname copy Svyatoslav Nikolenko
2026-09-01 10:09 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®