mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drivers/staging/axis-fifo: fix formatting issue
@ 2026-08-22  6:46 Arihan Bhor
  2026-09-01 10:11 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Arihan Bhor @ 2026-08-22  6:46 UTC (permalink / raw)
  To: gregkh
  Cc: ovidiu.panait.oss, gustavopiazdasilva210, error27, linux-staging,
	linux-kernel, Arihan Bhor

The issue as reported by checkpatch -

	CHECK: Alignment should match open parenthesis

	#249: FILE: drivers/staging/axis-fifo/axis-fifo.c:249:
	+		ret = wait_event_interruptible(fifo->write_queue,
	+			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);

Signed-off-by: Arihan Bhor <dogestad24@gmail.com>
---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870ea9..13a4f329a2e3 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr +
+							XLLF_TDFV_OFFSET) >= words_to_write);
 		if (ret)
 			goto end_unlock;
 	}

base-commit: 26260251022fbc2f248a3d747a9b2b961b18d2d8
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/staging/axis-fifo: fix formatting issue
  2026-08-22  6:46 [PATCH] drivers/staging/axis-fifo: fix formatting issue Arihan Bhor
@ 2026-09-01 10:11 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-09-01 10:11 UTC (permalink / raw)
  To: Arihan Bhor
  Cc: ovidiu.panait.oss, gustavopiazdasilva210, error27, linux-staging,
	linux-kernel

On Sat, Aug 22, 2026 at 12:16:27PM +0530, Arihan Bhor wrote:
> The issue as reported by checkpatch -
> 
> 	CHECK: Alignment should match open parenthesis
> 
> 	#249: FILE: drivers/staging/axis-fifo/axis-fifo.c:249:
> 	+		ret = wait_event_interruptible(fifo->write_queue,
> 	+			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> 
> Signed-off-by: Arihan Bhor <dogestad24@gmail.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..13a4f329a2e3 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr +
> +							XLLF_TDFV_OFFSET) >= words_to_write);
>  		if (ret)
>  			goto end_unlock;
>  	}
> 
> base-commit: 26260251022fbc2f248a3d747a9b2b961b18d2d8
> -- 
> 2.55.0
> 
> 

Does not apply to the staging-testing branch.  Can you please rebase and
resend?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-01 10:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-22  6:46 [PATCH] drivers/staging/axis-fifo: fix formatting issue Arihan Bhor
2026-09-01 10:11 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®