mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks
@ 2026-08-09 14:43 Andria Shengelia
  2026-09-01  9:59 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Andria Shengelia @ 2026-08-09 14:43 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Andria Shengelia

Reformat multi-line conditional expression wrapping in rtw_ap.c to fix
checkpatch.pl checks regarding logical continuations being placed at the
beginning of lines and lines ending with opening parentheses.

Signed-off-by: Andria Shengelia <shengeliaandria9@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index a6dc88dd4..9c14ba1dc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -258,11 +258,9 @@ void expire_timeout_chk(struct adapter *padapter)
 		} else {
 			/* TODO: Aging mechanism to digest frames in sleep_q to */
 			/* avoid running out of xmitframe */
-			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt)
-				&& padapter->xmitpriv.free_xmitframe_cnt < ((
-					NR_XMITFRAME / pstapriv->asoc_list_cnt
-				) / 2)
-			)
+			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
+			    padapter->xmitpriv.free_xmitframe_cnt <
+			    (NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2)
 				wakeup_sta_to_xmit(padapter, psta);
 		}
 	}
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks
  2026-08-09 14:43 [PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks Andria Shengelia
@ 2026-09-01  9:59 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-09-01  9:59 UTC (permalink / raw)
  To: Andria Shengelia; +Cc: linux-staging, linux-kernel

On Sun, Aug 09, 2026 at 06:43:55PM +0400, Andria Shengelia wrote:
> Reformat multi-line conditional expression wrapping in rtw_ap.c to fix
> checkpatch.pl checks regarding logical continuations being placed at the
> beginning of lines and lines ending with opening parentheses.
> 
> Signed-off-by: Andria Shengelia <shengeliaandria9@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index a6dc88dd4..9c14ba1dc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -258,11 +258,9 @@ void expire_timeout_chk(struct adapter *padapter)
>  		} else {
>  			/* TODO: Aging mechanism to digest frames in sleep_q to */
>  			/* avoid running out of xmitframe */
> -			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt)
> -				&& padapter->xmitpriv.free_xmitframe_cnt < ((
> -					NR_XMITFRAME / pstapriv->asoc_list_cnt
> -				) / 2)
> -			)
> +			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
> +			    padapter->xmitpriv.free_xmitframe_cnt <
> +			    (NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2)
>  				wakeup_sta_to_xmit(padapter, psta);
>  		}
>  	}
> -- 
> 2.55.0
> 
> 

Does not apply to the current staging-testing branch :(

Please rebase and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-01  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-09 14:43 [PATCH] staging: rtl8723bs: rtw_ap: fix line wrapping and logical continuation checks Andria Shengelia
2026-09-01  9:59 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®