[PATCH 0/5] xfs: remove leftover dead declarations in headers

[PATCH 0/5] xfs: remove leftover dead declarations in headers

[Zizhi Wo]

While reading the XFS log code I noticed that the implementation of
xlog_assign_tail_lsn() had already been removed, but its declaration was
left behind in the header. Such orphaned declarations (implementation gone,
no callers) can simply be dropped.

Suspecting more of these existed, I scanned the XFS headers (using GLM-5.2
to help, then verified each by hand) and this series removes the leftover
declarations I could confirm. Some of these have been stale for a long time
-- the oldest dates back to 2006.

Note that scrub still has a fair number of functions that do have
implementations but no callers (e.g. xchk_process_rt_error). I'm not sure
removing those is appropriate, since they may be intended for future use,
so they are not touched here.

Cleanup only, no functional change.

Zizhi Wo (5):
  xfs: remove unused xlog_assign_tail_lsn declarations
  xfs: remove unused xfs_iext_realloc declaration
  xfs: remove unused xfs_buf_iodone declaration
  xfs: remove unused kmem_to_page helper
  xfs: remove never-implemented scrub declarations

 fs/xfs/scrub/common.h   |  1 -
 fs/xfs/scrub/scrub.h    |  1 -
 fs/xfs/scrub/tempfile.h |  4 ----
 fs/xfs/xfs_buf_item.h   |  1 -
 fs/xfs/xfs_inode.h      |  1 -
 fs/xfs/xfs_log.h        |  2 --
 fs/xfs/xfs_platform.h   | 11 -----------
 7 files changed, 21 deletions(-)

-- 
2.52.0

[PATCH 1/5] xfs: remove unused xlog_assign_tail_lsn declarations

[Zizhi Wo]

From: Zizhi Wo <wozizhi@huawei.com>

Commit 0dcd5a10d987 ("xfs: l_last_sync_lsn is really AIL state") moved log
tail tracking entirely into the AIL and removed the implementations of
xlog_assign_tail_lsn() and xlog_assign_tail_lsn_locked(). The prototypes
for these two functions were left behind in xfs_log.h and no longer refer
to anything.

Remove the dangling declarations.

Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
 fs/xfs/xfs_log.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h
index ca66429bf6c9..f715695e8fcb 100644
--- a/fs/xfs/xfs_log.h
+++ b/fs/xfs/xfs_log.h
@@ -105,8 +105,6 @@ int	  xfs_log_mount(struct xfs_mount	*mp,
 			int		 	num_bblocks);
 int	  xfs_log_mount_finish(struct xfs_mount *mp);
 void	xfs_log_mount_cancel(struct xfs_mount *);
-xfs_lsn_t xlog_assign_tail_lsn(struct xfs_mount *mp);
-xfs_lsn_t xlog_assign_tail_lsn_locked(struct xfs_mount *mp);
 void	xfs_log_space_wake(struct xfs_mount *mp);
 int	xfs_log_reserve(struct xfs_mount *mp, int length, int count,
 			struct xlog_ticket **ticket, bool permanent);
-- 
2.52.0

[PATCH 2/5] xfs: remove unused xfs_iext_realloc declaration

[Zizhi Wo]

From: Zizhi Wo <wozizhi@huawei.com>

Commit 4eea22f01bb4 ("[XFS] 929045 567344 ...") removed the
xfs_iext_realloc() implementation, replacing it with xfs_iext_add() and
xfs_iext_remove(), but the declaration in xfs_inode.h was left behind.
It has been a dead prototype ever since (2006).

Remove the stale declaration.

Assisted-by: Claude-Code:GLM-5.2
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
 fs/xfs/xfs_inode.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index 34c1038ebfcd..1602027cd0aa 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -585,7 +585,6 @@ uint		xfs_ilock_attr_map_shared(struct xfs_inode *);
 int		xfs_ifree(struct xfs_trans *, struct xfs_inode *);
 int		xfs_itruncate_extents_flags(struct xfs_trans **,
 				struct xfs_inode *, int, xfs_fsize_t, int);
-void		xfs_iext_realloc(xfs_inode_t *, int, int);
 
 int		xfs_log_force_inode(struct xfs_inode *ip);
 void		xfs_iunpin_wait(xfs_inode_t *);
-- 
2.52.0

[PATCH 3/5] xfs: remove unused xfs_buf_iodone declaration

[Zizhi Wo]

From: Zizhi Wo <wozizhi@huawei.com>

Commit 664ffb8a429a ("xfs: move the buffer retry logic to xfs_buf.c")
removed the xfs_buf_iodone() implementation and its last caller in
favour of xfs_buf_ioend_finish(), but the declaration in xfs_buf_item.h was
left behind. It has been a dead prototype ever since (2020).

Remove the stale declaration.

Assisted-by: Claude-Code:GLM-5.2
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
 fs/xfs/xfs_buf_item.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_buf_item.h b/fs/xfs/xfs_buf_item.h
index 3159325dd17b..28c79989d725 100644
--- a/fs/xfs/xfs_buf_item.h
+++ b/fs/xfs/xfs_buf_item.h
@@ -60,7 +60,6 @@ static inline void xfs_buf_dquot_iodone(struct xfs_buf *bp)
 {
 }
 #endif /* CONFIG_XFS_QUOTA */
-void	xfs_buf_iodone(struct xfs_buf *);
 bool	xfs_buf_log_check_iovec(struct kvec *iovec);
 
 unsigned int xfs_buf_inval_log_space(unsigned int map_count,
-- 
2.52.0

[PATCH 4/5] xfs: remove unused kmem_to_page helper

[Zizhi Wo]

From: Zizhi Wo <wozizhi@huawei.com>

Commit 5ced480d4886 ("xfs: simplify building the bio in xlog_write_iclog")
switched the log I/O path to the bio_add_virt_nofail and bio_add_vmalloc
helpers, removing the last caller of kmem_to_page(). The helper itself was
left behind in xfs_platform.h and nothing has referenced it.

Remove the stale helper.

Assisted-by: Claude-Code:GLM-5.2
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
Note: this helper was only recently orphaned by 5ced480d4886 since 2025. If
it's intended to be kept for upcoming bio/vmalloc work, please just drop
this patch.

 fs/xfs/xfs_platform.h | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/fs/xfs/xfs_platform.h b/fs/xfs/xfs_platform.h
index 59a33c60e0ca..5d542e95fe44 100644
--- a/fs/xfs/xfs_platform.h
+++ b/fs/xfs/xfs_platform.h
@@ -289,15 +289,4 @@ int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count,
 # define PTR_FMT "%p"
 #endif
 
-/*
- * Helper for IO routines to grab backing pages from allocated kernel memory.
- */
-static inline struct page *
-kmem_to_page(void *addr)
-{
-	if (is_vmalloc_addr(addr))
-		return vmalloc_to_page(addr);
-	return virt_to_page(addr);
-}
-
 #endif /* _XFS_PLATFORM_H */
-- 
2.52.0

[PATCH 5/5] xfs: remove never-implemented scrub declarations

[Zizhi Wo]

From: Zizhi Wo <wozizhi@huawei.com>

Commit dcb660f9222f ("xfs: probe the scrub ioctl") added a declaration for
xfs_scrub_tester() (now xchk_tester) as a placeholder in 2017, but the
function was never implemented.

Likewise commit 99d9d8d05da2 ("xfs: scrub inode block mappings") declared
xfs_scrub_setup_inode_bmap_data() (now xchk_setup_inode_bmap_data) in 2017,
which was never implemented either; the scrub ioctl table uses
xchk_setup_inode_bmap() for BMBTD/BMBTA/BMBTC checks.

Finally, the !CONFIG_XFS_ONLINE_REPAIR stub of xrep_tempfile_iolock_both()
added by commit 84c14ee39dd3 ("xfs: create temporary files and directories
for online repair") has no callers.

Remove these dead declarations and the unused stub.

Assisted-by: Claude-Code:GLM-5.2
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
---
Note: if any of them are intended to be implemented in the future, please
just ignore the corresponding patch. I'm only sending these because they
have been sitting unimplemented since 2017.

 fs/xfs/scrub/common.h   | 1 -
 fs/xfs/scrub/scrub.h    | 1 -
 fs/xfs/scrub/tempfile.h | 4 ----
 3 files changed, 6 deletions(-)

diff --git a/fs/xfs/scrub/common.h b/fs/xfs/scrub/common.h
index 9d627fd50687..f0f073a93413 100644
--- a/fs/xfs/scrub/common.h
+++ b/fs/xfs/scrub/common.h
@@ -74,7 +74,6 @@ int xchk_setup_ag_rmapbt(struct xfs_scrub *sc);
 int xchk_setup_ag_refcountbt(struct xfs_scrub *sc);
 int xchk_setup_inode(struct xfs_scrub *sc);
 int xchk_setup_inode_bmap(struct xfs_scrub *sc);
-int xchk_setup_inode_bmap_data(struct xfs_scrub *sc);
 int xchk_setup_directory(struct xfs_scrub *sc);
 int xchk_setup_xattr(struct xfs_scrub *sc);
 int xchk_setup_symlink(struct xfs_scrub *sc);
diff --git a/fs/xfs/scrub/scrub.h b/fs/xfs/scrub/scrub.h
index 6d7d3523b71f..737a5d6db15f 100644
--- a/fs/xfs/scrub/scrub.h
+++ b/fs/xfs/scrub/scrub.h
@@ -261,7 +261,6 @@ static inline int xchk_nothing(struct xfs_scrub *sc)
 }
 
 /* Metadata scrubbers */
-int xchk_tester(struct xfs_scrub *sc);
 int xchk_superblock(struct xfs_scrub *sc);
 int xchk_agf(struct xfs_scrub *sc);
 int xchk_agfl(struct xfs_scrub *sc);
diff --git a/fs/xfs/scrub/tempfile.h b/fs/xfs/scrub/tempfile.h
index 71c1b54599c3..d44ed43bafe0 100644
--- a/fs/xfs/scrub/tempfile.h
+++ b/fs/xfs/scrub/tempfile.h
@@ -39,10 +39,6 @@ int xrep_tempfile_roll_trans(struct xfs_scrub *sc);
 void xrep_tempfile_copyout_local(struct xfs_scrub *sc, int whichfork);
 bool xrep_is_tempfile(const struct xfs_inode *ip);
 #else
-static inline void xrep_tempfile_iolock_both(struct xfs_scrub *sc)
-{
-	xchk_ilock(sc, XFS_IOLOCK_EXCL);
-}
 # define xrep_is_tempfile(ip)		(false)
 # define xrep_tempfile_adjust_directory_tree(sc)	(0)
 # define xrep_tempfile_rele(sc)
-- 
2.52.0

Re: [PATCH 0/5] xfs: remove leftover dead declarations in headers

[Darrick J. Wong]

On Fri, Sep 04, 2026 at 02:06:43PM +0800, Zizhi Wo wrote:
> While reading the XFS log code I noticed that the implementation of
> xlog_assign_tail_lsn() had already been removed, but its declaration was
> left behind in the header. Such orphaned declarations (implementation gone,
> no callers) can simply be dropped.
> 
> Suspecting more of these existed, I scanned the XFS headers (using GLM-5.2
> to help, then verified each by hand) and this series removes the leftover
> declarations I could confirm. Some of these have been stale for a long time
> -- the oldest dates back to 2006.
> 
> Note that scrub still has a fair number of functions that do have
> implementations but no callers (e.g. xchk_process_rt_error). I'm not sure
> removing those is appropriate, since they may be intended for future use,
> so they are not touched here.
> 
> Cleanup only, no functional change.

Looks fine to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> 
> Zizhi Wo (5):
>   xfs: remove unused xlog_assign_tail_lsn declarations
>   xfs: remove unused xfs_iext_realloc declaration
>   xfs: remove unused xfs_buf_iodone declaration
>   xfs: remove unused kmem_to_page helper
>   xfs: remove never-implemented scrub declarations
> 
>  fs/xfs/scrub/common.h   |  1 -
>  fs/xfs/scrub/scrub.h    |  1 -
>  fs/xfs/scrub/tempfile.h |  4 ----
>  fs/xfs/xfs_buf_item.h   |  1 -
>  fs/xfs/xfs_inode.h      |  1 -
>  fs/xfs/xfs_log.h        |  2 --
>  fs/xfs/xfs_platform.h   | 11 -----------
>  7 files changed, 21 deletions(-)
> 
> -- 
> 2.52.0
> 

Re: [PATCH 0/5] xfs: remove leftover dead declarations in headers

[Carlos Maiolino]

On Fri, Sep 04, 2026 at 02:06:43PM +0800, Zizhi Wo wrote:
> While reading the XFS log code I noticed that the implementation of
> xlog_assign_tail_lsn() had already been removed, but its declaration was
> left behind in the header. Such orphaned declarations (implementation gone,
> no callers) can simply be dropped.
> 
> Suspecting more of these existed, I scanned the XFS headers (using GLM-5.2
> to help, then verified each by hand) and this series removes the leftover
> declarations I could confirm. Some of these have been stale for a long time
> -- the oldest dates back to 2006.
> 
> Note that scrub still has a fair number of functions that do have
> implementations but no callers (e.g. xchk_process_rt_error). I'm not sure
> removing those is appropriate, since they may be intended for future use,
> so they are not touched here.
> 
> Cleanup only, no functional change.
> 
> Zizhi Wo (5):
>   xfs: remove unused xlog_assign_tail_lsn declarations
>   xfs: remove unused xfs_iext_realloc declaration
>   xfs: remove unused xfs_buf_iodone declaration
>   xfs: remove unused kmem_to_page helper
>   xfs: remove never-implemented scrub declarations

Honestly this all could have been a single patch, I don't believe the
'when the last user was gone' matters at least for me as I could find if
through a quick `git log` scan. Darrick was fine with it so I won't
enforce it to be a single cleanup patch.

At least get rid of the "Assisted-By: <model>" thing and send a new
version as we don't accept models discrimination anymore.

Carlos

> 
>  fs/xfs/scrub/common.h   |  1 -
>  fs/xfs/scrub/scrub.h    |  1 -
>  fs/xfs/scrub/tempfile.h |  4 ----
>  fs/xfs/xfs_buf_item.h   |  1 -
>  fs/xfs/xfs_inode.h      |  1 -
>  fs/xfs/xfs_log.h        |  2 --
>  fs/xfs/xfs_platform.h   | 11 -----------
>  7 files changed, 21 deletions(-)
> 
> -- 
> 2.52.0
> 
> 

Re: [PATCH 0/5] xfs: remove leftover dead declarations in headers

[Zizhi Wo]

在 2026/9/4 23:24, Carlos Maiolino 写道:
> On Fri, Sep 04, 2026 at 02:06:43PM +0800, Zizhi Wo wrote:
>> While reading the XFS log code I noticed that the implementation of
>> xlog_assign_tail_lsn() had already been removed, but its declaration was
>> left behind in the header. Such orphaned declarations (implementation gone,
>> no callers) can simply be dropped.
>>
>> Suspecting more of these existed, I scanned the XFS headers (using GLM-5.2
>> to help, then verified each by hand) and this series removes the leftover
>> declarations I could confirm. Some of these have been stale for a long time
>> -- the oldest dates back to 2006.
>>
>> Note that scrub still has a fair number of functions that do have
>> implementations but no callers (e.g. xchk_process_rt_error). I'm not sure
>> removing those is appropriate, since they may be intended for future use,
>> so they are not touched here.
>>
>> Cleanup only, no functional change.
>>
>> Zizhi Wo (5):
>>    xfs: remove unused xlog_assign_tail_lsn declarations
>>    xfs: remove unused xfs_iext_realloc declaration
>>    xfs: remove unused xfs_buf_iodone declaration
>>    xfs: remove unused kmem_to_page helper
>>    xfs: remove never-implemented scrub declarations
> 

Hi Carlos,

Thanks a lot for the review.

> Honestly this all could have been a single patch, I don't believe the
> 'when the last user was gone' matters at least for me as I could find if
> through a quick `git log` scan. Darrick was fine with it so I won't
> enforce it to be a single cleanup patch.
> 

My original intent behind splitting was to keep each removal in its own
commit, so that during review one could tell directly from the commit
message why each symbol was left behind, without having to dig through
the history separately -- even though every change is tiny.

But I agree that a quick `git log` scan serves the same purpose, so I'll
fold them into a single cleanup patch in v2.


> At least get rid of the "Assisted-By: <model>" thing and send a new
> version as we don't accept models discrimination anymore.
> 
> Carlos
> 

Sure, I'll drop the "Assisted-By:" tag as well.
Will send v2 shortly.

Thanks,
Zizhi Wo

>>
>>   fs/xfs/scrub/common.h   |  1 -
>>   fs/xfs/scrub/scrub.h    |  1 -
>>   fs/xfs/scrub/tempfile.h |  4 ----
>>   fs/xfs/xfs_buf_item.h   |  1 -
>>   fs/xfs/xfs_inode.h      |  1 -
>>   fs/xfs/xfs_log.h        |  2 --
>>   fs/xfs/xfs_platform.h   | 11 -----------
>>   7 files changed, 21 deletions(-)
>>
>> -- 
>> 2.52.0
>>
>>