* [PATCH net-next] net: dsa: motorcomm: Handle degenerated blink delays
@ 2026-09-04 13:47 David Yang
0 siblings, 0 replies; only message in thread
From: David Yang @ 2026-09-04 13:47 UTC (permalink / raw)
To: netdev
Cc: David Yang, Andrew Lunn, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-kernel
The LED core defines delay_on == 0 as steady off and delay_off == 0 as
steady on, which was treated as a blink in our LED driver. Fix it.
Fixes: 9af9a8168213 ("net: dsa: motorcomm: Add LED support")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/dsa/motorcomm/leds.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/motorcomm/leds.c b/drivers/net/dsa/motorcomm/leds.c
index 7d3c0f68d8ff..87a6b9cf6068 100644
--- a/drivers/net/dsa/motorcomm/leds.c
+++ b/drivers/net/dsa/motorcomm/leds.c
@@ -107,6 +107,8 @@ yt921x_led_blink_set(struct yt921x_priv *priv, int port, int group,
YT921X_LED_DUTY(1, 2);
use_cycle = false;
+ } else if (!*onp || !*offp) {
+ return yt921x_led_force_set(priv, port, group, *onp);
} else {
res = yt921x_led_blink_select(priv, *onp, *offp, &cycle, &duty);
if (res)
--
2.53.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-04 13:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-04 13:47 [PATCH net-next] net: dsa: motorcomm: Handle degenerated blink delays David Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®