From: Jonathan Cameron <jic23@kernel.org>
To: "hpp.iscas" <hppiscas@163.com>
Cc: "Petre Rodan" <petre.rodan@subdimension.ro>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tiberiu Breana" <tiberiu.a.breana@intel.com>
Subject: Re: [PATCH] iio: accel: bma220: Publish the SPI driver's ACPI alias
Date: Sun, 6 Sep 2026 00:16:30 +0100 [thread overview]
Message-ID: <20260906001630.392bb533@jic23-huawei> (raw)
In-Reply-To: <20260905133901.66016-1-hppiscas@163.com>
On Sat, 5 Sep 2026 21:39:01 +0800
"hpp.iscas" <hppiscas@163.com> wrote:
> The BMA220 SPI driver registers an ACPI match table containing BMA0220,
> but exports only its SPI and OF tables. SPI devices with an ACPI
> companion emit an ACPI modalias, which neither existing table covers.
>
> Publish the ACPI table without changing either of the other matches.
>
> Fixes: bf2a5600a3eb ("iio: accel: Add support for Bosch BMA220")
> Signed-off-by: hpp.iscas <hppiscas@163.com>
Same issue. I see Guenter also replied with similar. We need something
more 'known' as an identity. I see you sent quite a few patches out on
similar issues. I'd suggest perhaps focusing on just getting one or two
through the process as it will save time on duplicated feedback like this.
You can scale up later!
one other thing inline.
> ---
> drivers/iio/accel/bma220_spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c
> index d6c1087..13b156b 100644
> --- a/drivers/iio/accel/bma220_spi.c
> +++ b/drivers/iio/accel/bma220_spi.c
> @@ -33,6 +33,7 @@ static const struct acpi_device_id bma220_acpi_id[] = {
> { "BMA0220", 0 },
This line has changed suggesting you are working on on old tree. Give
7.3-rc1 is out, that is a good base for new pathes at this point.
> { }
> };
> +MODULE_DEVICE_TABLE(acpi, bma220_acpi_id);
> MODULE_DEVICE_TABLE(spi, bma220_spi_id);
This line should be under the spi_device_id table, so please move it in this
patch as well as adding the acpi one.
>
> static const struct of_device_id bma220_of_spi_match[] = {
>
next prev parent reply other threads:[~2026-09-05 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 13:39 hpp.iscas
2026-09-05 23:16 ` Jonathan Cameron [this message]
2026-09-08 9:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906001630.392bb533@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=hppiscas@163.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=tiberiu.a.breana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®