From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "hpp.iscas" <hppiscas@163.com>
Cc: "Petre Rodan" <petre.rodan@subdimension.ro>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tiberiu Breana" <tiberiu.a.breana@intel.com>
Subject: Re: [PATCH] iio: accel: bma220: Publish the SPI driver's ACPI alias
Date: Tue, 8 Sep 2026 12:55:29 +0300 [thread overview]
Message-ID: <ap_bkdMOMw6HEgTn@ashevche-desk.local> (raw)
In-Reply-To: <20260905133901.66016-1-hppiscas@163.com>
On Sat, Sep 05, 2026 at 09:39:01PM +0800, hpp.iscas wrote:
> The BMA220 SPI driver registers an ACPI match table containing BMA0220,
> but exports only its SPI and OF tables. SPI devices with an ACPI
> companion emit an ACPI modalias, which neither existing table covers.
>
> Publish the ACPI table without changing either of the other matches.
...
> static const struct acpi_device_id bma220_acpi_id[] = {
> { "BMA0220", 0 },
> { }
> };
> +MODULE_DEVICE_TABLE(acpi, bma220_acpi_id);
> MODULE_DEVICE_TABLE(spi, bma220_spi_id);
Ouch! This one needs to be moved closer to the respective (SPI) ID table
definition.
> static const struct of_device_id bma220_of_spi_match[] = {
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-08 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 13:39 hpp.iscas
2026-09-05 23:16 ` Jonathan Cameron
2026-09-08 9:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_bkdMOMw6HEgTn@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=hppiscas@163.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=tiberiu.a.breana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®