* [PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs
@ 2026-09-06 0:49 Lalit Shankar Chowdhury
2026-09-06 7:31 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Lalit Shankar Chowdhury @ 2026-09-06 0:49 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Andy Shevchenko, Greg Kroah-Hartman,
open list:STAGING - ATOMISP DRIVER,
open list:INTEL MID (Mobile Internet Device) PLATFORM,
open list:STAGING SUBSYSTEM
Cc: Lalit Shankar Chowdhury
Use designated initializers for the ACPI ID tables.
Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++--
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index f9cc5f45fe00..588f2f90a884 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -857,8 +857,8 @@ static int gc2235_probe(struct i2c_client *client)
}
static const struct acpi_device_id gc2235_acpi_match[] = {
- { "INT33F8" },
- {},
+ { .id = "INT33F8" },
+ { },
};
MODULE_DEVICE_TABLE(acpi, gc2235_acpi_match);
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 2c41c496daa6..b02fe0c915ab 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -995,8 +995,8 @@ static int ov2722_probe(struct i2c_client *client)
}
static const struct acpi_device_id ov2722_acpi_match[] = {
- { "INT33FB" },
- {},
+ { .id = "INT33FB" },
+ { },
};
MODULE_DEVICE_TABLE(acpi, ov2722_acpi_match);
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs
2026-09-06 0:49 [PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs Lalit Shankar Chowdhury
@ 2026-09-06 7:31 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-09-06 7:31 UTC (permalink / raw)
To: Lalit Shankar Chowdhury
Cc: Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Andy Shevchenko, Greg Kroah-Hartman,
open list:STAGING - ATOMISP DRIVER,
open list:INTEL MID (Mobile Internet Device) PLATFORM,
open list:STAGING SUBSYSTEM
On Sun, Sep 6, 2026 at 3:53 AM Lalit Shankar Chowdhury
<lalitshankarch@gmail.com> wrote:
>
> Use designated initializers for the ACPI ID tables.
...
> static const struct acpi_device_id gc2235_acpi_match[] = {
> - { "INT33F8" },
> - {},
> + { .id = "INT33F8" },
> + { },
Follow the agreed style for the terminator entry. See Uwe's patches as
an example.
> };
...
> static const struct acpi_device_id ov2722_acpi_match[] = {
> - { "INT33FB" },
> - {},
> + { .id = "INT33FB" },
> + { },
Ditto.
> };
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-06 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-06 0:49 [PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs Lalit Shankar Chowdhury
2026-09-06 7:31 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®