mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] isofs: fix repeated word 'in' in comment
@ 2026-09-04 12:39 Hemanth Selam
  2026-09-07  4:24 ` Hemanth Selam
  2026-09-07  8:13 ` Jan Kara
  0 siblings, 2 replies; 4+ messages in thread
From: Hemanth Selam @ 2026-09-04 12:39 UTC (permalink / raw)
  To: Jan Kara; +Cc: linux-kernel, linux-fsdevel

Drop the second 'in', reported by checkpatch.pl as a possible repeated
word.  Only touches a comment, no code changes.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 fs/isofs/compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
index f9869d62b850..9efd7a9082e3 100644
--- a/fs/isofs/compress.c
+++ b/fs/isofs/compress.c
@@ -90,7 +90,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
 	/*
 	 * First block is special since it may be fractional.  We also wait for
 	 * it before grabbing the zlib mutex; odds are that the subsequent
-	 * blocks are going to come in in short order so we don't hold the zlib
+	 * blocks are going to come in short order so we don't hold the zlib
 	 * mutex longer than necessary.
 	 */
 
-- 
2.48.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] isofs: fix repeated word 'in' in comment
  2026-09-04 12:39 [PATCH] isofs: fix repeated word 'in' in comment Hemanth Selam
@ 2026-09-07  4:24 ` Hemanth Selam
  2026-09-07  8:15   ` Jan Kara
  2026-09-07  8:13 ` Jan Kara
  1 sibling, 1 reply; 4+ messages in thread
From: Hemanth Selam @ 2026-09-07  4:24 UTC (permalink / raw)
  To: Jan Kara; +Cc: linux-kernel, linux-fsdevel

Please drop this patch, it is wrong.

  "the subsequent blocks are going to come in in short order"

"come in" is the verb and "in short order" is the adverbial that follows
it.  Both words belong there and the comment reads correctly as it is.

I matched the doubled word without reading the sentence.  Sorry for the
noise.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] isofs: fix repeated word 'in' in comment
  2026-09-04 12:39 [PATCH] isofs: fix repeated word 'in' in comment Hemanth Selam
  2026-09-07  4:24 ` Hemanth Selam
@ 2026-09-07  8:13 ` Jan Kara
  1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2026-09-07  8:13 UTC (permalink / raw)
  To: Hemanth Selam; +Cc: Jan Kara, linux-kernel, linux-fsdevel

On Fri 04-09-26 18:09:13, Hemanth Selam wrote:
> Drop the second 'in', reported by checkpatch.pl as a possible repeated
> word.  Only touches a comment, no code changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/isofs/compress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
> index f9869d62b850..9efd7a9082e3 100644
> --- a/fs/isofs/compress.c
> +++ b/fs/isofs/compress.c
> @@ -90,7 +90,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start,
>  	/*
>  	 * First block is special since it may be fractional.  We also wait for
>  	 * it before grabbing the zlib mutex; odds are that the subsequent
> -	 * blocks are going to come in in short order so we don't hold the zlib
> +	 * blocks are going to come in short order so we don't hold the zlib
>  	 * mutex longer than necessary.
>  	 */
>  
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] isofs: fix repeated word 'in' in comment
  2026-09-07  4:24 ` Hemanth Selam
@ 2026-09-07  8:15   ` Jan Kara
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2026-09-07  8:15 UTC (permalink / raw)
  To: Hemanth Selam; +Cc: Jan Kara, linux-kernel, linux-fsdevel

On Mon 07-09-26 09:54:02, Hemanth Selam wrote:
> Please drop this patch, it is wrong.
> 
>   "the subsequent blocks are going to come in in short order"
> 
> "come in" is the verb and "in short order" is the adverbial that follows
> it.  Both words belong there and the comment reads correctly as it is.

Ah right. It actually makes sense both ways but you are right the change is
unnecessary. Dropping.
	
								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-07  8:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-04 12:39 [PATCH] isofs: fix repeated word 'in' in comment Hemanth Selam
2026-09-07  4:24 ` Hemanth Selam
2026-09-07  8:15   ` Jan Kara
2026-09-07  8:13 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®