mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] fpga: fix typo in s10_ops_write() comment
@ 2026-09-07  4:43 Hemanth Selam
  2026-09-09  6:56 ` Xu Yilun
  0 siblings, 1 reply; 2+ messages in thread
From: Hemanth Selam @ 2026-09-07  4:43 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix; +Cc: linux-fpga, linux-kernel

The comment reads "reuse it to send more data or free if if all data has
been sent".  The first "if" is not a repetition, it should be "it", to
match the "reuse it" earlier in the same sentence.

v1 deleted the second "if" instead, which left the sentence without an
object.  Xu Yilun pointed out the correct reading.

Only touches a comment, no code changes.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/fpga/stratix10-soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index b8ec2e6f615f..5aed560050c2 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -286,7 +286,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
 
 	/*
 	 * Loop waiting for buffers to be returned.  When a buffer is returned,
-	 * reuse it to send more data or free if if all data has been sent.
+	 * reuse it to send more data or free it if all data has been sent.
 	 */
 	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
 		reinit_completion(&priv->status_return_completion);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] fpga: fix typo in s10_ops_write() comment
  2026-09-07  4:43 [PATCH v2] fpga: fix typo in s10_ops_write() comment Hemanth Selam
@ 2026-09-09  6:56 ` Xu Yilun
  0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2026-09-09  6:56 UTC (permalink / raw)
  To: Hemanth Selam; +Cc: Moritz Fischer, Xu Yilun, Tom Rix, linux-fpga, linux-kernel

On Mon, Sep 07, 2026 at 10:13:44AM +0530, Hemanth Selam wrote:
> The comment reads "reuse it to send more data or free if if all data has
> been sent".  The first "if" is not a repetition, it should be "it", to
> match the "reuse it" earlier in the same sentence.
> 
> v1 deleted the second "if" instead, which left the sentence without an
> object.  Xu Yilun pointed out the correct reading.

These change history should not belong to the changelog. Put them under
--- so they won't appear when applied.

> 
> Only touches a comment, no code changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/fpga/stratix10-soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index b8ec2e6f615f..5aed560050c2 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -286,7 +286,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>  
>  	/*
>  	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> -	 * reuse it to send more data or free if if all data has been sent.
> +	 * reuse it to send more data or free it if all data has been sent.
>  	 */
>  	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
>  		reinit_completion(&priv->status_return_completion);
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-09  6:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-07  4:43 [PATCH v2] fpga: fix typo in s10_ops_write() comment Hemanth Selam
2026-09-09  6:56 ` Xu Yilun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®