[PATCH v2] power: reset: keystone: fix missing space in error message

[PATCH v2] power: reset: keystone: fix missing space in error message

[Hemanth Selam]

The two string literals are concatenated, so the message prints
"has to contain atleast one entry".

v1 added the missing space but kept the string split across two lines.
Krzysztof Kozlowski pointed out the string should not be wrapped at all,
which also matches coding-style.rst: never break user-visible strings,
because that breaks the ability to grep for them.  Join it into one
line instead; the result exceeds 80 columns, which is expected for a
user-visible string.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/power/reset/keystone-reset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/power/reset/keystone-reset.c b/drivers/power/reset/keystone-reset.c
index 3c44cd6cee0a..491ba490b8ea 100644
--- a/drivers/power/reset/keystone-reset.c
+++ b/drivers/power/reset/keystone-reset.c
@@ -112,8 +112,7 @@ static int rsctrl_probe(struct platform_device *pdev)
 	for (i = 0; i < WDT_MUX_NUMBER; i++) {
 		ret = of_property_read_u32_index(np, "ti,wdt-list", i, &val);
 		if (ret == -EOVERFLOW && !i) {
-			dev_err(dev, "ti,wdt-list property has to contain at"
-				"least one entry\n");
+			dev_err(dev, "ti,wdt-list property has to contain at least one entry\n");
 			return -EINVAL;
 		} else if (ret) {
 			break;

Re: [PATCH v2] power: reset: keystone: fix missing space in error message

[Sebastian Reichel]

On Mon, 07 Sep 2026 14:42:12 +0530, Hemanth Selam wrote:
> The two string literals are concatenated, so the message prints
> "has to contain atleast one entry".
> 
> v1 added the missing space but kept the string split across two lines.
> Krzysztof Kozlowski pointed out the string should not be wrapped at all,
> which also matches coding-style.rst: never break user-visible strings,
> because that breaks the ability to grep for them.  Join it into one
> line instead; the result exceeds 80 columns, which is expected for a
> user-visible string.
> 
> [...]

Applied, thanks!

[1/1] power: reset: keystone: fix missing space in error message
      commit: 49ee04619f820ac0e5ca618dfc0657229eadeddc

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>