mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] btrfs: fix typos and repeated words in comments
@ 2026-09-07  4:48 Hemanth Selam
  2026-09-07  9:15 ` Daniel Vacek
  2026-09-07 10:06 ` David Sterba
  0 siblings, 2 replies; 5+ messages in thread
From: Hemanth Selam @ 2026-09-07  4:48 UTC (permalink / raw)
  To: Chris Mason, David Sterba; +Cc: linux-btrfs, linux-kernel

Fix misspellings and repeated words in comments, found with
scripts/checkpatch.pl and codespell.  Only touches comments, no code
changes.

Changes since v1:
 - the typo and repeated-word patches are folded into one, as they only
   touch comments
 - rebased onto btrfs for-next
 - picked up the further typos codespell found, which David Sterba
   listed: Temporarilly, Checksume, coresponding, caclulated, wheather
   and cannnot ("commited" in block-group.h was already fixed by v1)

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 fs/btrfs/block-group.h          | 2 +-
 fs/btrfs/extent-io-tree.c       | 2 +-
 fs/btrfs/fs.c                   | 2 +-
 fs/btrfs/raid56.c               | 8 ++++----
 fs/btrfs/send.c                 | 2 +-
 fs/btrfs/transaction.h          | 2 +-
 fs/btrfs/tree-checker.c         | 2 +-
 include/uapi/linux/btrfs_tree.h | 4 ++--
 8 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/fs/btrfs/block-group.h b/fs/btrfs/block-group.h
index 69d56864d4ba..b349f94cf929 100644
--- a/fs/btrfs/block-group.h
+++ b/fs/btrfs/block-group.h
@@ -135,7 +135,7 @@ struct btrfs_block_group {
 	u64 global_root_id;
 	u64 remap_bytes;
 	u32 identity_remap_count;
-	/* The last commited identity_remap_count value of this block group. */
+	/* The last committed identity_remap_count value of this block group. */
 	u32 last_identity_remap_count;
 	/*
 	 * The last committed used bytes of this block group, if the above @used
diff --git a/fs/btrfs/extent-io-tree.c b/fs/btrfs/extent-io-tree.c
index d6df11f6088c..992b8b42bdb4 100644
--- a/fs/btrfs/extent-io-tree.c
+++ b/fs/btrfs/extent-io-tree.c
@@ -751,7 +751,7 @@ int btrfs_clear_extent_bit_changeset(struct extent_io_tree *tree, u64 start, u64
 				btrfs_split_delalloc_extent(tree->inode, state, start);
 
 			/*
-			 * Temporarilly ajdust this state's range to match the
+			 * Temporarily ajdust this state's range to match the
 			 * range for which we are clearing bits.
 			 */
 			state->start = start;
diff --git a/fs/btrfs/fs.c b/fs/btrfs/fs.c
index de160d29dde8..75a1217727a7 100644
--- a/fs/btrfs/fs.c
+++ b/fs/btrfs/fs.c
@@ -79,7 +79,7 @@ void btrfs_csum_init(struct btrfs_csum_ctx *ctx, u16 csum_type)
 		blake2b_init(&ctx->blake2b, 32);
 		break;
 	default:
-		/* Checksume type is validated at mount time. */
+		/* Checksum type is validated at mount time. */
 		BUG();
 	}
 }
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index a5d0ef09d92a..4f702dbf581b 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -953,7 +953,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
 
 	/*
 	 * Clear the data bitmap, as the rbio may be cached for later usage.
-	 * do this before before unlock_stripe() so there will be no new bio
+	 * do this before unlock_stripe() so there will be no new bio
 	 * for this bio.
 	 */
 	bitmap_clear(&rbio->dbitmap, 0, rbio->stripe_nsectors);
@@ -988,7 +988,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
  * as possible, and only use stripe_sectors as fallback.
  *
  * Return NULL if bio_list_only is set but the specified sector has no
- * coresponding bio.
+ * corresponding bio.
  */
 static phys_addr_t *sector_paddrs_in_rbio(struct btrfs_raid_bio *rbio,
 					  int stripe_nr, int sector_nr,
@@ -1451,7 +1451,7 @@ static int rmw_assemble_write_bios(struct btrfs_raid_bio *rbio,
 	ASSERT(bitmap_weight(&rbio->dbitmap, rbio->stripe_nsectors));
 
 	/*
-	 * Reset errors, as we may have errors inherited from from degraded
+	 * Reset errors, as we may have errors inherited from degraded
 	 * write.
 	 */
 	bitmap_clear(rbio->error_bitmap, 0, rbio->nr_sectors);
@@ -2632,7 +2632,7 @@ static int alloc_rbio_essential_pages(struct btrfs_raid_bio *rbio)
 	return 0;
 }
 
-/* Return true if the content of the step matches the caclulated one. */
+/* Return true if the content of the step matches the calculated one. */
 static bool verify_one_parity_step(struct btrfs_raid_bio *rbio,
 				   void *pointers[], unsigned int sector_nr,
 				   unsigned int step_nr)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 5c59b9abedcd..c523bf950c89 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -7023,7 +7023,7 @@ static int changed_extent(struct send_ctx *sctx,
 	 * get modified or replaced with a new one). Note that deduplication
 	 * updates the inode item, but it only changes the iversion (sequence
 	 * field in the inode item) of the inode, so if a file is deduplicated
-	 * the same amount of times in both the parent and send snapshots, its
+	 * the same number of times in both the parent and send snapshots, its
 	 * iversion becomes the same in both snapshots, whence the inode item is
 	 * the same on both snapshots.
 	 */
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
index 3a57f227b5ed..89153cd22596 100644
--- a/fs/btrfs/transaction.h
+++ b/fs/btrfs/transaction.h
@@ -288,7 +288,7 @@ do {										\
  * Call btrfs_abort_transaction() as early as possible when an error condition
  * is detected, that way the exact stack trace is reported for some errors.
  *
- * Error number must be negative as it encodes wheather it's the first abort.
+ * Error number must be negative as it encodes whether it's the first abort.
  */
 #define btrfs_abort_transaction(trans, error)		\
 do {								\
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index 401fd40ec7b2..b8ca9980e1dd 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -228,7 +228,7 @@ static bool can_have_extent_data(struct extent_buffer *leaf,
 	}
 
 	/*
-	 * The rest are special files, e.g. block/FIFO files, which cannnot
+	 * The rest are special files, e.g. block/FIFO files, which cannot
 	 * have any file extent.
 	 */
 	return false;
diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
index b6ccaf848e4b..47ee52859b45 100644
--- a/include/uapi/linux/btrfs_tree.h
+++ b/include/uapi/linux/btrfs_tree.h
@@ -230,7 +230,7 @@
  *
  * Stored as an inline ref rather to avoid wasting space on a separate item on
  * top of the existing extent item. However, unlike the other inline refs,
- * there is one one owner ref per extent rather than one per extent.
+ * there is one owner ref per extent rather than one per extent.
  *
  * Because of this, it goes at the front of the list of inline refs, and thus
  * must have a lower type value than any other inline ref type (to satisfy the
@@ -243,7 +243,7 @@
 #define BTRFS_EXTENT_DATA_REF_KEY	178
 
 /*
- * Obsolete key. Defintion removed in 6.6, value may be reused in the future.
+ * Obsolete key. Definition removed in 6.6, value may be reused in the future.
  *
  * #define BTRFS_EXTENT_REF_V0_KEY	180
  */

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] btrfs: fix typos and repeated words in comments
  2026-09-07  4:48 [PATCH v2] btrfs: fix typos and repeated words in comments Hemanth Selam
@ 2026-09-07  9:15 ` Daniel Vacek
  2026-09-07  9:22   ` David Sterba
  2026-09-07 10:06 ` David Sterba
  1 sibling, 1 reply; 5+ messages in thread
From: Daniel Vacek @ 2026-09-07  9:15 UTC (permalink / raw)
  To: Hemanth Selam; +Cc: Chris Mason, David Sterba, linux-btrfs, linux-kernel

On Mon, 7 Sept 2026 at 06:54, Hemanth Selam <hemanth.selam@gmail.com> wrote:
> Fix misspellings and repeated words in comments, found with
> scripts/checkpatch.pl and codespell.  Only touches comments, no code
> changes.
>
> Changes since v1:
>  - the typo and repeated-word patches are folded into one, as they only
>    touch comments
>  - rebased onto btrfs for-next
>  - picked up the further typos codespell found, which David Sterba
>    listed: Temporarilly, Checksume, coresponding, caclulated, wheather
>    and cannnot ("commited" in block-group.h was already fixed by v1)
>
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  fs/btrfs/block-group.h          | 2 +-
>  fs/btrfs/extent-io-tree.c       | 2 +-
>  fs/btrfs/fs.c                   | 2 +-
>  fs/btrfs/raid56.c               | 8 ++++----
>  fs/btrfs/send.c                 | 2 +-
>  fs/btrfs/transaction.h          | 2 +-
>  fs/btrfs/tree-checker.c         | 2 +-
>  include/uapi/linux/btrfs_tree.h | 4 ++--
>  8 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/fs/btrfs/block-group.h b/fs/btrfs/block-group.h
> index 69d56864d4ba..b349f94cf929 100644
> --- a/fs/btrfs/block-group.h
> +++ b/fs/btrfs/block-group.h
> @@ -135,7 +135,7 @@ struct btrfs_block_group {
>         u64 global_root_id;
>         u64 remap_bytes;
>         u32 identity_remap_count;
> -       /* The last commited identity_remap_count value of this block group. */
> +       /* The last committed identity_remap_count value of this block group. */
>         u32 last_identity_remap_count;
>         /*
>          * The last committed used bytes of this block group, if the above @used
> diff --git a/fs/btrfs/extent-io-tree.c b/fs/btrfs/extent-io-tree.c
> index d6df11f6088c..992b8b42bdb4 100644
> --- a/fs/btrfs/extent-io-tree.c
> +++ b/fs/btrfs/extent-io-tree.c
> @@ -751,7 +751,7 @@ int btrfs_clear_extent_bit_changeset(struct extent_io_tree *tree, u64 start, u64
>                                 btrfs_split_delalloc_extent(tree->inode, state, start);
>
>                         /*
> -                        * Temporarilly ajdust this state's range to match the
> +                        * Temporarily ajdust this state's range to match the
>                          * range for which we are clearing bits.
>                          */
>                         state->start = start;
> diff --git a/fs/btrfs/fs.c b/fs/btrfs/fs.c
> index de160d29dde8..75a1217727a7 100644
> --- a/fs/btrfs/fs.c
> +++ b/fs/btrfs/fs.c
> @@ -79,7 +79,7 @@ void btrfs_csum_init(struct btrfs_csum_ctx *ctx, u16 csum_type)
>                 blake2b_init(&ctx->blake2b, 32);
>                 break;
>         default:
> -               /* Checksume type is validated at mount time. */
> +               /* Checksum type is validated at mount time. */
>                 BUG();
>         }
>  }
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index a5d0ef09d92a..4f702dbf581b 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -953,7 +953,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
>
>         /*
>          * Clear the data bitmap, as the rbio may be cached for later usage.
> -        * do this before before unlock_stripe() so there will be no new bio
> +        * do this before unlock_stripe() so there will be no new bio
>          * for this bio.

The sentence should start with a capital. Perhaps it would also fit
into two lines?

>          */
>         bitmap_clear(&rbio->dbitmap, 0, rbio->stripe_nsectors);
> @@ -988,7 +988,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
>   * as possible, and only use stripe_sectors as fallback.
>   *
>   * Return NULL if bio_list_only is set but the specified sector has no
> - * coresponding bio.
> + * corresponding bio.
>   */
>  static phys_addr_t *sector_paddrs_in_rbio(struct btrfs_raid_bio *rbio,
>                                           int stripe_nr, int sector_nr,
> @@ -1451,7 +1451,7 @@ static int rmw_assemble_write_bios(struct btrfs_raid_bio *rbio,
>         ASSERT(bitmap_weight(&rbio->dbitmap, rbio->stripe_nsectors));
>
>         /*
> -        * Reset errors, as we may have errors inherited from from degraded
> +        * Reset errors, as we may have errors inherited from degraded
>          * write.

This can fit on one line.

--nX

>          */
>         bitmap_clear(rbio->error_bitmap, 0, rbio->nr_sectors);
> @@ -2632,7 +2632,7 @@ static int alloc_rbio_essential_pages(struct btrfs_raid_bio *rbio)
>         return 0;
>  }
>
> -/* Return true if the content of the step matches the caclulated one. */
> +/* Return true if the content of the step matches the calculated one. */
>  static bool verify_one_parity_step(struct btrfs_raid_bio *rbio,
>                                    void *pointers[], unsigned int sector_nr,
>                                    unsigned int step_nr)
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index 5c59b9abedcd..c523bf950c89 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -7023,7 +7023,7 @@ static int changed_extent(struct send_ctx *sctx,
>          * get modified or replaced with a new one). Note that deduplication
>          * updates the inode item, but it only changes the iversion (sequence
>          * field in the inode item) of the inode, so if a file is deduplicated
> -        * the same amount of times in both the parent and send snapshots, its
> +        * the same number of times in both the parent and send snapshots, its
>          * iversion becomes the same in both snapshots, whence the inode item is
>          * the same on both snapshots.
>          */
> diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
> index 3a57f227b5ed..89153cd22596 100644
> --- a/fs/btrfs/transaction.h
> +++ b/fs/btrfs/transaction.h
> @@ -288,7 +288,7 @@ do {                                                                                \
>   * Call btrfs_abort_transaction() as early as possible when an error condition
>   * is detected, that way the exact stack trace is reported for some errors.
>   *
> - * Error number must be negative as it encodes wheather it's the first abort.
> + * Error number must be negative as it encodes whether it's the first abort.
>   */
>  #define btrfs_abort_transaction(trans, error)          \
>  do {                                                           \
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 401fd40ec7b2..b8ca9980e1dd 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -228,7 +228,7 @@ static bool can_have_extent_data(struct extent_buffer *leaf,
>         }
>
>         /*
> -        * The rest are special files, e.g. block/FIFO files, which cannnot
> +        * The rest are special files, e.g. block/FIFO files, which cannot
>          * have any file extent.
>          */
>         return false;
> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
> index b6ccaf848e4b..47ee52859b45 100644
> --- a/include/uapi/linux/btrfs_tree.h
> +++ b/include/uapi/linux/btrfs_tree.h
> @@ -230,7 +230,7 @@
>   *
>   * Stored as an inline ref rather to avoid wasting space on a separate item on
>   * top of the existing extent item. However, unlike the other inline refs,
> - * there is one one owner ref per extent rather than one per extent.
> + * there is one owner ref per extent rather than one per extent.
>   *
>   * Because of this, it goes at the front of the list of inline refs, and thus
>   * must have a lower type value than any other inline ref type (to satisfy the
> @@ -243,7 +243,7 @@
>  #define BTRFS_EXTENT_DATA_REF_KEY      178
>
>  /*
> - * Obsolete key. Defintion removed in 6.6, value may be reused in the future.
> + * Obsolete key. Definition removed in 6.6, value may be reused in the future.
>   *
>   * #define BTRFS_EXTENT_REF_V0_KEY     180
>   */
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] btrfs: fix typos and repeated words in comments
  2026-09-07  9:15 ` Daniel Vacek
@ 2026-09-07  9:22   ` David Sterba
  2026-09-07  9:58     ` Daniel Vacek
  0 siblings, 1 reply; 5+ messages in thread
From: David Sterba @ 2026-09-07  9:22 UTC (permalink / raw)
  To: Daniel Vacek
  Cc: Hemanth Selam, Chris Mason, David Sterba, linux-btrfs, linux-kernel

On Mon, Sep 07, 2026 at 11:15:33AM +0200, Daniel Vacek wrote:
> > --- a/fs/btrfs/raid56.c
> > +++ b/fs/btrfs/raid56.c
> > @@ -953,7 +953,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
> >
> >         /*
> >          * Clear the data bitmap, as the rbio may be cached for later usage.
> > -        * do this before before unlock_stripe() so there will be no new bio
> > +        * do this before unlock_stripe() so there will be no new bio
> >          * for this bio.
> 
> The sentence should start with a capital. Perhaps it would also fit
> into two lines?

Reformatting whole lines makes the typos harder to spot, so it's fine to
leave it like that and reformat at commit time eventually.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] btrfs: fix typos and repeated words in comments
  2026-09-07  9:22   ` David Sterba
@ 2026-09-07  9:58     ` Daniel Vacek
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vacek @ 2026-09-07  9:58 UTC (permalink / raw)
  To: dsterba
  Cc: Hemanth Selam, Chris Mason, David Sterba, linux-btrfs, linux-kernel

On Mon, 7 Sept 2026 at 11:22, David Sterba <dsterba@suse.cz> wrote:
> On Mon, Sep 07, 2026 at 11:15:33AM +0200, Daniel Vacek wrote:
> > > --- a/fs/btrfs/raid56.c
> > > +++ b/fs/btrfs/raid56.c
> > > @@ -953,7 +953,7 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
> > >
> > >         /*
> > >          * Clear the data bitmap, as the rbio may be cached for later usage.
> > > -        * do this before before unlock_stripe() so there will be no new bio
> > > +        * do this before unlock_stripe() so there will be no new bio
> > >          * for this bio.
> >
> > The sentence should start with a capital. Perhaps it would also fit
> > into two lines?
>
> Reformatting whole lines makes the typos harder to spot, so it's fine to
> leave it like that and reformat at commit time eventually.

Right, I see. Sorry about the noise then.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] btrfs: fix typos and repeated words in comments
  2026-09-07  4:48 [PATCH v2] btrfs: fix typos and repeated words in comments Hemanth Selam
  2026-09-07  9:15 ` Daniel Vacek
@ 2026-09-07 10:06 ` David Sterba
  1 sibling, 0 replies; 5+ messages in thread
From: David Sterba @ 2026-09-07 10:06 UTC (permalink / raw)
  To: Hemanth Selam; +Cc: Chris Mason, David Sterba, linux-btrfs, linux-kernel

On Mon, Sep 07, 2026 at 10:18:01AM +0530, Hemanth Selam wrote:
> Fix misspellings and repeated words in comments, found with
> scripts/checkpatch.pl and codespell.  Only touches comments, no code
> changes.
> 
> Changes since v1:
>  - the typo and repeated-word patches are folded into one, as they only
>    touch comments
>  - rebased onto btrfs for-next
>  - picked up the further typos codespell found, which David Sterba
>    listed: Temporarilly, Checksume, coresponding, caclulated, wheather
>    and cannnot ("commited" in block-group.h was already fixed by v1)
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>

Added to for-next, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-07 10:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-07  4:48 [PATCH v2] btrfs: fix typos and repeated words in comments Hemanth Selam
2026-09-07  9:15 ` Daniel Vacek
2026-09-07  9:22   ` David Sterba
2026-09-07  9:58     ` Daniel Vacek
2026-09-07 10:06 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®