mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] btrfs: reflow comments left awkward by the typo fixes
@ 2026-09-07 11:41 Hemanth Selam
  2026-09-07 11:48 ` Hemanth Selam
  2026-09-07 12:35 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: Hemanth Selam @ 2026-09-07 11:41 UTC (permalink / raw)
  To: David Sterba; +Cc: Daniel Vacek, Chris Mason, linux-btrfs, linux-kernel

Removing the repeated words in rbio_orig_end_io() and
rmw_assemble_write_bios() left two comments reading oddly: one now starts
its second sentence in lower case and wraps early, and the other fits on a
single line.  Reflow both, as Daniel Vacek pointed out.

Comments only, no functional changes.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 fs/btrfs/raid56.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index 4f702dbf581b..47d6a313cbdf 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -953,8 +953,8 @@ static void rbio_orig_end_io(struct btrfs_raid_bio *rbio, blk_status_t status)
 
 	/*
 	 * Clear the data bitmap, as the rbio may be cached for later usage.
-	 * do this before unlock_stripe() so there will be no new bio
-	 * for this bio.
+	 * Do this before unlock_stripe() so there will be no new bio for this
+	 * bio.
 	 */
 	bitmap_clear(&rbio->dbitmap, 0, rbio->stripe_nsectors);
 
@@ -1450,10 +1450,7 @@ static int rmw_assemble_write_bios(struct btrfs_raid_bio *rbio,
 	/* We should have at least one data sector. */
 	ASSERT(bitmap_weight(&rbio->dbitmap, rbio->stripe_nsectors));
 
-	/*
-	 * Reset errors, as we may have errors inherited from degraded
-	 * write.
-	 */
+	/* Reset errors, as we may have errors inherited from degraded write. */
 	bitmap_clear(rbio->error_bitmap, 0, rbio->nr_sectors);
 
 	/*
-- 
2.48.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: reflow comments left awkward by the typo fixes
  2026-09-07 11:41 [PATCH] btrfs: reflow comments left awkward by the typo fixes Hemanth Selam
@ 2026-09-07 11:48 ` Hemanth Selam
  2026-09-07 12:35 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Hemanth Selam @ 2026-09-07 11:48 UTC (permalink / raw)
  To: David Sterba; +Cc: Daniel Vacek, Chris Mason, linux-btrfs, linux-kernel

Please drop this patch.

You had already answered the question it tries to address:

  "Reformatting whole lines makes the typos harder to spot, so it's fine
   to leave it like that and reformat at commit time eventually."

I sent it after reading Daniel's comments but before reading your reply
to them, so I reflowed the two comments you had just said not to reflow.
Entirely my fault, and easily avoided if I had read the whole thread
first.  Sorry for the noise.

The typo fixes already in for-next are unaffected.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: reflow comments left awkward by the typo fixes
  2026-09-07 11:41 [PATCH] btrfs: reflow comments left awkward by the typo fixes Hemanth Selam
  2026-09-07 11:48 ` Hemanth Selam
@ 2026-09-07 12:35 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2026-09-07 12:35 UTC (permalink / raw)
  To: Hemanth Selam
  Cc: David Sterba, Daniel Vacek, Chris Mason, linux-btrfs, linux-kernel

On Mon, Sep 07, 2026 at 05:11:53PM +0530, Hemanth Selam wrote:
> Removing the repeated words in rbio_orig_end_io() and
> rmw_assemble_write_bios() left two comments reading oddly: one now starts
> its second sentence in lower case and wraps early, and the other fits on a
> single line.  Reflow both, as Daniel Vacek pointed out.
> 
> Comments only, no functional changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>

No need to send such patches if thery're an immediate followup, the
change can be done at commit time. This saves time on both sides.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-07 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-07 11:41 [PATCH] btrfs: reflow comments left awkward by the typo fixes Hemanth Selam
2026-09-07 11:48 ` Hemanth Selam
2026-09-07 12:35 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®