From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Sean Anderson <sean.anderson@linux.dev>,
Steven Rostedt <rostedt@goodmis.org>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
donggeunyoo.kernel@gmail.com
Subject: Re: [PATCH] dma-mapping: don't trace the DMA address when the allocation fails
Date: Mon, 7 Sep 2026 21:01:56 +0900 [thread overview]
Message-ID: <20260907120156.603600-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <ff20483d-c701-4cdb-8db8-15aa79bc32cf@samsung.com>
On Mon, Sep 07, 2026 at 01:05:20PM +0200, Marek Szyprowski wrote:
> Frankly speaking I would prefer to fix this in include/trace/events/dma.h with
> __entry->dma_addr = virt_addr ? dma_addr : 0;
Agreed, that is better. It also covers dma_alloc_pages() and
dma_alloc_sgt_err(), which share dma_alloc_class, and any caller added
later.
> Here You remove the debug_dma_alloc call for the failed case. Right, it
> is a noop now for the allocation failure, but it might be extended with
> some kind of debugging in the future, so I prefer to keep the current
> code here.
Fair enough. kernel/dma/mapping.c is untouched in v2.
include/trace/events/dma.h is not covered by the DMA MAINTAINERS entry,
only by TRACING, so v2 has Steven and Masami on To as well.
v2, tested this time rather than compile-tested only:
https://lore.kernel.org/linux-iommu/20260907120124.603373-1-donggeunyoo.kernel@gmail.com/
prev parent reply other threads:[~2026-09-07 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260905071928eucas1p1c5690e441968982d4acd9ea1c43b02e5@eucas1p1.samsung.com>
2026-09-05 7:19 ` Donggeun Yoo
2026-09-05 12:57 ` Sean Anderson
2026-09-05 17:26 ` Donggeun Yoo
2026-09-05 18:37 ` Sean Anderson
2026-09-05 19:16 ` Donggeun Yoo
2026-09-07 11:05 ` Marek Szyprowski
2026-09-07 12:01 ` Donggeun Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907120156.603600-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®