From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix comment formatting for pintf_dev in rtw_io.h
Date: Mon, 7 Sep 2026 18:30:04 +0200 [thread overview]
Message-ID: <2026090744-jolt-unnamed-8d58@gregkh> (raw)
In-Reply-To: <20260905-rtl8723bs-rtw-io-comment-v2-v2-1-ee5791206cdb@yahoo.pl>
On Sat, Sep 05, 2026 at 07:23:45PM +0200, Tomasz Unger wrote:
> Add a space before the comment, remove the stray space before a tab
> inside it, and drop the unnecessary parentheses around
> &padapter->dvobjpriv.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Dan Carpenter reviewed the previous "space before tab" comment fix
> for rtw_io.h and pointed out two more issues in the same comment: a
> missing space before the comment itself, and unnecessary parentheses.
>
> This v2 fixes both, per his review.
> ---
> Changes in v2 (per Dan Carpenter's review):
> - Dan noted there should be a space before the comment, and that the
> parentheses around &(padapter->dvobjpriv) are unnecessary. Both are
> fixed here, in addition to the original space-before-tab fix.
> - Add an Assisted-by: trailer disclosing AI assistance, per
> Documentation/process/coding-assistants.rst (the original v1 had no
> such disclosure).
>
> Verified with checkpatch.pl - no new warnings introduced by this change
> (and removes a pre-existing "space before tabs" warning on the modified line).
>
> Assisted-by: Claude:claude-sonnet-5
Please see:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
prev parent reply other threads:[~2026-09-07 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260905-rtl8723bs-rtw-io-comment-v2-v2-1-ee5791206cdb.ref@yahoo.pl>
2026-09-05 17:23 ` Tomasz Unger
2026-09-07 16:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090744-jolt-unnamed-8d58@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®