* [PATCH v2] staging: rtl8723bs: fix comment formatting for pintf_dev in rtw_io.h [not found] <20260905-rtl8723bs-rtw-io-comment-v2-v2-1-ee5791206cdb.ref@yahoo.pl> @ 2026-09-05 17:23 ` Tomasz Unger 2026-09-07 16:30 ` Greg Kroah-Hartman 0 siblings, 1 reply; 2+ messages in thread From: Tomasz Unger @ 2026-09-05 17:23 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Tomasz Unger Add a space before the comment, remove the stray space before a tab inside it, and drop the unnecessary parentheses around &padapter->dvobjpriv. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- Dan Carpenter reviewed the previous "space before tab" comment fix for rtw_io.h and pointed out two more issues in the same comment: a missing space before the comment itself, and unnecessary parentheses. This v2 fixes both, per his review. --- Changes in v2 (per Dan Carpenter's review): - Dan noted there should be a space before the comment, and that the parentheses around &(padapter->dvobjpriv) are unnecessary. Both are fixed here, in addition to the original space-before-tab fix. - Add an Assisted-by: trailer disclosing AI assistance, per Documentation/process/coding-assistants.rst (the original v1 had no such disclosure). Verified with checkpatch.pl - no new warnings introduced by this change (and removes a pre-existing "space before tabs" warning on the modified line). Assisted-by: Claude:claude-sonnet-5 --- drivers/staging/rtl8723bs/include/rtw_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h index 3c99a2bc19bd..a613db80d349 100644 --- a/drivers/staging/rtl8723bs/include/rtw_io.h +++ b/drivers/staging/rtl8723bs/include/rtw_io.h @@ -24,7 +24,7 @@ struct _io_ops { struct intf_hdl { struct adapter *padapter; - struct dvobj_priv *pintf_dev;/* pointer to &(padapter->dvobjpriv); */ + struct dvobj_priv *pintf_dev; /* pointer to &padapter->dvobjpriv */ struct _io_ops io_ops; }; --- base-commit: c6eb4dc5964fdf4086b73b7f0f5dc0d595fb5cf3 change-id: 20260905-rtl8723bs-rtw-io-comment-v2-b02c1b4200e1 Best regards, -- Tomasz Unger <tomasz.unger@yahoo.pl> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: fix comment formatting for pintf_dev in rtw_io.h 2026-09-05 17:23 ` [PATCH v2] staging: rtl8723bs: fix comment formatting for pintf_dev in rtw_io.h Tomasz Unger @ 2026-09-07 16:30 ` Greg Kroah-Hartman 0 siblings, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2026-09-07 16:30 UTC (permalink / raw) To: Tomasz Unger; +Cc: linux-staging, linux-kernel On Sat, Sep 05, 2026 at 07:23:45PM +0200, Tomasz Unger wrote: > Add a space before the comment, remove the stray space before a tab > inside it, and drop the unnecessary parentheses around > &padapter->dvobjpriv. > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > Dan Carpenter reviewed the previous "space before tab" comment fix > for rtw_io.h and pointed out two more issues in the same comment: a > missing space before the comment itself, and unnecessary parentheses. > > This v2 fixes both, per his review. > --- > Changes in v2 (per Dan Carpenter's review): > - Dan noted there should be a space before the comment, and that the > parentheses around &(padapter->dvobjpriv) are unnecessary. Both are > fixed here, in addition to the original space-before-tab fix. > - Add an Assisted-by: trailer disclosing AI assistance, per > Documentation/process/coding-assistants.rst (the original v1 had no > such disclosure). > > Verified with checkpatch.pl - no new warnings introduced by this change > (and removes a pre-existing "space before tabs" warning on the modified line). > > Assisted-by: Claude:claude-sonnet-5 Please see: https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-07 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20260905-rtl8723bs-rtw-io-comment-v2-v2-1-ee5791206cdb.ref@yahoo.pl>
2026-09-05 17:23 ` [PATCH v2] staging: rtl8723bs: fix comment formatting for pintf_dev in rtw_io.h Tomasz Unger
2026-09-07 16:30 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®