* [PATCHv2] ARM: dts: marvell: armada-388: use onnn,pca9655 compatible
@ 2026-09-08 6:04 Rosen Penev
0 siblings, 0 replies; 2+ messages in thread
From: Rosen Penev @ 2026-09-08 6:04 UTC (permalink / raw)
To: devicetree
Cc: Russell King, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:ARM/Marvell Kirkwood and Armada 370,
375, 38x,...,
open list
The PCA9655s on the ClearFog and Helios4 boards are
register-compatible with the pca9555, and the gpio-pca953x driver has
matched "onnn,pca9655" in its OF match table since
commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655"). OF matching is tried before the legacy I2C ID-table
matching that the old comment alluded to, so the restriction no longer
applies. List the real part and drop the stale comment.
The I2C client is now named "pca9655" instead of "pca9555", but the
expander is otherwise identical.
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: rebase.
arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi | 7 +------
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 9 +--------
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
index f8a06ae4a3c9..4a61e9d1a2c0 100644
--- a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
+++ b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
@@ -131,12 +131,7 @@ &i2c0 {
* 15-SFP_MOD_DEF0
*/
expander0: gpio-expander@20 {
- /*
- * This is how it should be:
- * compatible = "onnn,pca9655", "nxp,pca9555";
- * but you can't do this because of the way I2C works.
- */
- compatible = "nxp,pca9555";
+ compatible = "onnn,pca9655";
gpio-controller;
#gpio-cells = <2>;
reg = <0x20>;
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 39b2d4fa742c..bf6d70e2078b 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -160,14 +160,7 @@ i2c@11000 {
* 6-USB3 power
*/
expander0: gpio-expander@20 {
- /*
- * This is how it should be:
- * compatible = "onnn,pca9655",
- * "nxp,pca9555";
- * but you can't do this because of
- * the way I2C works.
- */
- compatible = "nxp,pca9555";
+ compatible = "onnn,pca9655";
gpio-controller;
#gpio-cells = <2>;
reg = <0x20>;
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCHv2] ARM: dts: marvell: armada-388: use onnn,pca9655 compatible
@ 2026-09-07 0:59 Rosen Penev
0 siblings, 0 replies; 2+ messages in thread
From: Rosen Penev @ 2026-09-07 0:59 UTC (permalink / raw)
To: devicetree
Cc: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Russell King, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
open list
The PCA9655s on the ClearFog and Helios4 boards are
register-compatible with the pca9555, and the gpio-pca953x driver has
matched "onnn,pca9655" in its OF match table since
commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655"). OF matching is tried before the legacy I2C ID-table
matching that the old comment alluded to, so the restriction no longer
applies. List the real part and drop the stale comment.
The I2C client is now named "pca9655" instead of "pca9555", but the
expander is otherwise identical.
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: rebase so it applies
arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi | 7 +------
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 9 +--------
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
index f8a06ae4a3c9..4a61e9d1a2c0 100644
--- a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
+++ b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
@@ -131,12 +131,7 @@ &i2c0 {
* 15-SFP_MOD_DEF0
*/
expander0: gpio-expander@20 {
- /*
- * This is how it should be:
- * compatible = "onnn,pca9655", "nxp,pca9555";
- * but you can't do this because of the way I2C works.
- */
- compatible = "nxp,pca9555";
+ compatible = "onnn,pca9655";
gpio-controller;
#gpio-cells = <2>;
reg = <0x20>;
diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 39b2d4fa742c..bf6d70e2078b 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -160,14 +160,7 @@ i2c@11000 {
* 6-USB3 power
*/
expander0: gpio-expander@20 {
- /*
- * This is how it should be:
- * compatible = "onnn,pca9655",
- * "nxp,pca9555";
- * but you can't do this because of
- * the way I2C works.
- */
- compatible = "nxp,pca9555";
+ compatible = "onnn,pca9655";
gpio-controller;
#gpio-cells = <2>;
reg = <0x20>;
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-08 6:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-08 6:04 [PATCHv2] ARM: dts: marvell: armada-388: use onnn,pca9655 compatible Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2026-09-07 0:59 Rosen Penev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®