[PATCH net-next v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup

[PATCH net-next v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no optional IRQ is available. Other errors should be propagated so
that the caller can handle them appropriately.

The existing code propagates -EPROBE_DEFER, but ignores other negative
errors. Propagate negative errors other than -ENXIO.

Found by manual code inspection.

Fixes: e1f550dc44a4 ("net: mvmdio: avoid error message for optional IRQ")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

Changes in v2:
 - Add a Fixes tag.
 - Add net-next to the --subject-prefix.


 drivers/net/ethernet/marvell/mvmdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index 2ccb8c8f5feb..d59cf332d1ec 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -373,8 +373,8 @@ static int orion_mdio_probe(struct platform_device *pdev)
 		writel(MVMDIO_ERR_INT_SMI_DONE,
 			dev->regs + MVMDIO_ERR_INT_MASK);
 
-	} else if (dev->err_interrupt == -EPROBE_DEFER) {
-		ret = -EPROBE_DEFER;
+	} else if (dev->err_interrupt < 0 && dev->err_interrupt != -ENXIO) {
+		ret = dev->err_interrupt;
 		goto out_mdio;
 	}
 
-- 
2.43.0

Re: [PATCH net-next v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup

[Simon Horman]

On Thu, Sep 03, 2026 at 02:46:38PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no optional IRQ is available. Other errors should be propagated so
> that the caller can handle them appropriately.
> 
> The existing code propagates -EPROBE_DEFER, but ignores other negative
> errors. Propagate negative errors other than -ENXIO.
> 
> Found by manual code inspection.
> 
> Fixes: e1f550dc44a4 ("net: mvmdio: avoid error message for optional IRQ")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> Changes in v2:
>  - Add a Fixes tag.
>  - Add net-next to the --subject-prefix.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup

[Paolo Abeni]

On 9/3/26 9:46 AM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no optional IRQ is available. Other errors should be propagated so
> that the caller can handle them appropriately.
> 
> The existing code propagates -EPROBE_DEFER, but ignores other negative
> errors. Propagate negative errors other than -ENXIO.
> 
> Found by manual code inspection.
> 
> Fixes: e1f550dc44a4 ("net: mvmdio: avoid error message for optional IRQ")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> Changes in v2:
>  - Add a Fixes tag.
>  - Add net-next to the --subject-prefix.
It's one or the other: no fixes tag for net-next patches.

This does not look like stable material, stripping the fixes tag.

/P

Re: [PATCH net-next v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu,  3 Sep 2026 14:46:38 +0700 you wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no optional IRQ is available. Other errors should be propagated so
> that the caller can handle them appropriately.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: marvell: mvmdio: Handle errors from optional IRQ lookup
    https://git.kernel.org/netdev/net-next/c/3ef961d01c2c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html