* [PATCHv2] dmaengine: bestcomm: ata: drop unused local variable 'inc'
@ 2026-09-08 21:33 Rosen Penev
2026-09-10 14:10 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-09-08 21:33 UTC (permalink / raw)
To: dmaengine
Cc: Vinod Koul, Frank Li, Nathan Chancellor, Nick Desaulniers,
Bill Wendling, Justin Stitt, open list,
open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b
bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
was never read, tripping clang -Wunused-but-set-variable:
drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
used [-Werror,-Wunused-but-set-variable]
58 | struct bcom_ata_inc *inc;
| ^
Drop the declaration and the bcom_task_inc() call that fed it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
v2: use suggested title
drivers/dma/bestcomm/ata.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/bestcomm/ata.c b/drivers/dma/bestcomm/ata.c
index 502a45d76adc..40126f3f189e 100644
--- a/drivers/dma/bestcomm/ata.c
+++ b/drivers/dma/bestcomm/ata.c
@@ -55,7 +55,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
{
struct bcom_task *tsk;
struct bcom_ata_var *var;
- struct bcom_ata_inc *inc;
/* Prefetch breaks ATA DMA. Turn it off for ATA DMA */
bcom_disable_prefetch();
@@ -69,7 +68,6 @@ bcom_ata_init(int queue_len, int maxbufsize)
bcom_ata_reset_bd(tsk);
var = (struct bcom_ata_var *) bcom_task_var(tsk->tasknum);
- inc = (struct bcom_ata_inc *) bcom_task_inc(tsk->tasknum);
if (bcom_load_image(tsk->tasknum, bcom_ata_task)) {
bcom_task_free(tsk);
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCHv2] dmaengine: bestcomm: ata: drop unused local variable 'inc'
2026-09-08 21:33 [PATCHv2] dmaengine: bestcomm: ata: drop unused local variable 'inc' Rosen Penev
@ 2026-09-10 14:10 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2026-09-10 14:10 UTC (permalink / raw)
To: dmaengine, Rosen Penev
Cc: Frank Li, Nathan Chancellor, Nick Desaulniers, Bill Wendling,
Justin Stitt, linux-kernel, llvm
On Tue, 08 Sep 2026 14:33:34 -0700, Rosen Penev wrote:
> bcom_ata_init() declared and assigned a struct bcom_ata_inc *inc that
> was never read, tripping clang -Wunused-but-set-variable:
>
> drivers/dma/bestcomm/ata.c:58:23: error: variable 'inc' set but not
> used [-Werror,-Wunused-but-set-variable]
> 58 | struct bcom_ata_inc *inc;
> | ^
>
> [...]
Applied, thanks!
[1/1] dmaengine: bestcomm: ata: drop unused local variable 'inc'
commit: db1a748a3509da959c547689af40e8a064a19c6b
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-10 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-08 21:33 [PATCHv2] dmaengine: bestcomm: ata: drop unused local variable 'inc' Rosen Penev
2026-09-10 14:10 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®