[PATCH RESEND 1/2] media: i2c: isl7998x: Inline i2c_check_functionality() check

[PATCH RESEND 1/2] media: i2c: isl7998x: Inline i2c_check_functionality() check

[Thorsten Blum]

Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
Wolfram, could you please apply this last conversion, since this patch
has not been applied yet despite several resends since April? Thanks.
---
 drivers/media/i2c/isl7998x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
index a77538d2343c..8244d4296a02 100644
--- a/drivers/media/i2c/isl7998x.c
+++ b/drivers/media/i2c/isl7998x.c
@@ -1460,8 +1460,7 @@ static int isl7998x_probe(struct i2c_client *client)
 	int nr_inputs;
 	int ret;
 
-	ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) {
 		dev_warn(&adapter->dev,
 			 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n");
 		return -EIO;

[PATCH RESEND 2/2] i2c: Change return type to bool for i2c_check_functionality()

[Thorsten Blum]

i2c_check_functionality() returns a bool - change the return type from
int to bool and update the comment accordingly.

Signed-off-by: Thorsten Blum <blum@kernel.org>
Acked-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
---
 include/linux/i2c.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 14ab4d3055af..4af2df969a05 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -919,8 +919,8 @@ static inline u32 i2c_get_functionality(struct i2c_adapter *adap)
 	return adap->algo->functionality(adap);
 }
 
-/* Return 1 if adapter supports everything we need, 0 if not. */
-static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func)
+/* Return true if adapter supports everything we need, false if not. */
+static inline bool i2c_check_functionality(struct i2c_adapter *adap, u32 func)
 {
 	return (func & i2c_get_functionality(adap)) == func;
 }

Re: [PATCH RESEND 2/2] i2c: Change return type to bool for i2c_check_functionality()

[Andi Shyti]

Hi Thorsten,

On Wed, Sep 09, 2026 at 10:20:56AM +0200, Thorsten Blum wrote:
> i2c_check_functionality() returns a bool - change the return type from
> int to bool and update the comment accordingly.
> 
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> Acked-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>

both patches merged to i2c/i2c.

For some reason I don't see anywhere in my mailbox your patch
1/1, I had to fish it out from patchwork.

Thanks,
Andi

Re: [PATCH RESEND 2/2] i2c: Change return type to bool for i2c_check_functionality()

[Thorsten Blum]

On Wed, Sep 09, 2026 at 06:31:14PM +0200, Andi Shyti wrote:
> Hi Thorsten,
> 
> On Wed, Sep 09, 2026 at 10:20:56AM +0200, Thorsten Blum wrote:
> > i2c_check_functionality() returns a bool - change the return type from
> > int to bool and update the comment accordingly.
> > 
> > Signed-off-by: Thorsten Blum <blum@kernel.org>
> > Acked-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
> 
> both patches merged to i2c/i2c.
> 
> For some reason I don't see anywhere in my mailbox your patch
> 1/1, I had to fish it out from patchwork.

I might have messed up the git send-email recipients and my config ended
up adding you only to patch 2/2. Apologies!

Thanks,
Thorsten