mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Hui Su <sh_def@163.com>
Cc: mingo@redhat.com, tim.c.chen@linux.intel.com,
	yu.c.chen@intel.com, kprateek.nayak@amd.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	connoro@google.com, jstultz@google.com, arighi@nvidia.com,
	tj@kernel.org, void@manifault.com, changwoo@igalia.com,
	linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev
Subject: Re: [PATCH v4 4/5] sched/rt: Fix RT watchdog accounting for proxy execution
Date: Wed, 9 Sep 2026 13:04:38 +0200	[thread overview]
Message-ID: <20260909110438.GA4120091@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260909092901.2989564-5-sh_def@163.com>

On Wed, Sep 09, 2026 at 06:29:00PM +0900, Hui Su wrote:

> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 05e599665fdd..d8a785bec639 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6768,6 +6768,14 @@ static bool try_to_block_task(struct rq *rq, struct task_struct *p,
>  		return false;
>  	}
>  
> +	/*
> +	 * Proxy execution can keep a mutex-blocked task on the runqueue, so it
> +	 * may not pass through ENQUEUE_WAKEUP, which normally resets the RT
> +	 * watchdog interval.
> +	 */
> +	if (sched_proxy_exec() && p->rt.timeout)
> +		p->rt.timeout = 0;
> +
>  	p->is_blocked = 1;
>  
>  	/*
> @@ -7243,6 +7251,16 @@ static void __sched notrace __schedule(int sched_mode)
>  		rq_set_donor(rq, next);
>  	}
>  
> +	/*
> +	 * End a previous RT proxy watchdog interval once neither context is
> +	 * in the RT class. Preserve the interval for an RT-policy task that is
> +	 * temporarily PI-boosted into the DL class.
> +	 */
> +	if (sched_proxy_exec() && !task_has_rt_policy(next) &&
> +	    !rt_prio(next->prio) &&
> +	    !rt_prio(rq->donor->prio) && next->rt.timeout)
> +		next->rt.timeout = 0;
> +
>  picked:
>  	clear_tsk_need_resched(prev);
>  	clear_preempt_need_resched();

It might come as no surprise that this isn't going to fly. I've not
though about the problem yet, but we're not going to be sprinkling rt
bits like this in the middle of __schedule().

  reply	other threads:[~2026-09-09 11:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  9:28 [PATCH v4 0/5] sched: Handle split scheduling and execution contexts in task ticks Hui Su
2026-09-09  9:28 ` [PATCH v4 1/5] sched: Dispatch task ticks for donor and execution classes Hui Su
2026-09-09 10:42   ` Hui Su
2026-09-09 17:43     ` Andrea Righi
2026-09-10 10:49       ` Hui Su
2026-09-09  9:28 ` [PATCH v4 2/5] sched/numa: Drive NUMA task tick from execution context Hui Su
2026-09-09  9:28 ` [PATCH v4 3/5] sched/cache: Drive cache " Hui Su
2026-09-09 11:03   ` Peter Zijlstra
2026-09-10 10:53     ` Hui Su
2026-09-09  9:29 ` [PATCH v4 4/5] sched/rt: Fix RT watchdog accounting for proxy execution Hui Su
2026-09-09 11:04   ` Peter Zijlstra [this message]
2026-09-10 10:54     ` Hui Su
2026-09-09  9:29 ` [PATCH v4 5/5] sched/core: Fix donor slice accounting under " Hui Su
2026-09-10 10:55   ` Hui Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909110438.GA4120091@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=connoro@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=sh_def@163.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®