From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Pascal Eberhard <pascal.eberhard@se.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: timer: Add the Renesas RZ/N1 timer
Date: Wed, 9 Sep 2026 12:06:25 +0200 [thread overview]
Message-ID: <20260909120625.726f191f@bootlin.com> (raw)
In-Reply-To: <CAMuHMdUn+di4YWAGS+CeBiCD_9EhqUz0O4FkuHZwmPo531+7Tg@mail.gmail.com>
Hi Geert, Wolfram,
On Wed, 5 Aug 2026 09:46:41 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Wolfram,
>
> On Tue, 4 Aug 2026 at 22:06, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > On Tue, Jul 21, 2026 at 10:29:47AM +0200, Herve Codina (Schneider Electric) wrote:
> > > The Renesas RZ/N1 timer block controller is the controller in charge of
> > > timers available in the Renesas RZ/N1 SoCs family.
> > >
> > > This controller handles 8 timers:
> > > - 6 16-bit timers
> > > - 2 32-bit timers
> > >
> > > Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > In general:
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > One nit:
> >
> > > + reg = <0x51001000 0x400>;
> >
> > Isn't 0x400 a bit excessive? The last documented register in my docs is
> > 0x114, so maybe 0x200 will do above?
>
> FTR, 0x200 or 0x400 does not make much of a difference, as this is
> mapped in PAGE_SIZE units anyway.
>
> According to Table 2.1 ("Register Map") in the RZ/N1 Introduction
> document it could even be 0x1000...
>
In order to be consistent with register listing available in the docs,
I plan to reduce the size to 0x200 in the next iteration.
Let me know if you disagree with that.
Best regards,
Hervé
next prev parent reply other threads:[~2026-09-09 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 8:29 [PATCH v4 0/4] timers: Add support for RZ/N1 SoCs timers Herve Codina (Schneider Electric)
2026-07-21 8:29 ` [PATCH v4 1/4] dt-bindings: timer: Add the Renesas RZ/N1 timer Herve Codina (Schneider Electric)
2026-08-04 20:06 ` Wolfram Sang
2026-08-05 7:46 ` Geert Uytterhoeven
2026-09-09 10:06 ` Herve Codina [this message]
2026-07-21 8:29 ` [PATCH v4 2/4] clocksource/drivers: Add support for the Renesas RZ/N1 timers Herve Codina (Schneider Electric)
2026-08-04 20:30 ` Wolfram Sang
2026-08-05 7:31 ` Wolfram Sang
2026-09-09 9:44 ` Herve Codina
2026-07-21 8:29 ` [PATCH v4 3/4] ARM: dts: r9a06g032: Add support for timers Herve Codina (Schneider Electric)
2026-08-04 20:30 ` Wolfram Sang
2026-07-21 8:29 ` [PATCH v4 4/4] MAINTAINERS: Add the Renesas RZ/N1 timers driver entry Herve Codina (Schneider Electric)
2026-08-04 20:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909120625.726f191f@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=robh@kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®