mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: b9788213@gmail.com
To: fahmymohammed@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style in HalBtc8723b2Ant.c
Date: Wed,  9 Sep 2026 15:36:13 +0300	[thread overview]
Message-ID: <20260909123648.174428-1-b9788213@gmail.com> (raw)
In-Reply-To: <20260908025910.155625-1-fahmymohammed@gmail.com>

On Mon 7 Sep 2026 20:57:57 -0600, Fahmy Hassan wrote:
> Address checkpatch.pl warnings listed in the driver's TODO file:
> remove braces around single-statement if/else arms, wrap function
> calls that exceed the 100 column limit, and move trailing comments
> that pushed lines over the limit onto their own line above the
> statement they document.

...

> -				if (bBtHsOn) {
> -				} else {
> +				if (bBtHsOn)
> +					;
> +				else
>  					algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;
> -				}

You can use something like

if (!bBtHsOn)
	algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;

Thanks,
Bera

  reply	other threads:[~2026-09-09 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  2:57 Fahmy Hassan
2026-09-09 12:36 ` b9788213 [this message]
     [not found]   ` <CAChV6vw0-6ZjfPCgjQ46mfEpnnJd51EGW-Dt1Wc8SWMkh+AwAg@mail.gmail.com>
2026-09-09 18:30     ` Fahmy Hassan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909123648.174428-1-b9788213@gmail.com \
    --to=b9788213@gmail.com \
    --cc=fahmymohammed@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®